Ticket #4519 (closed defect: fixed)

Opened 3 months ago

Last modified 3 months ago

php syntax: single line # style comments don't have to begin at the beginning of the line

Reported by: purdeaandrei Owned by: andrew_b
Priority: minor Milestone: 4.8.32
Component: mcedit Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset: committed-master

Description

See here: ​https://www.php.net/manual/en/language.basic-syntax.comments.php

the example is given clearly, the # does not start at the beginning of the line.

I have tried the following change, and it highlights my files correctly:

  • misc/syntax/php.syntax 

    diff --git a/misc/syntax/php.syntax b/misc/syntax/php.syntax
index b1ba3da8b..b3f7f79fd 100644
    a b context exclusive /\* \*/ brown 
    31563156context exclusive // \n brown 
    31573157    spellcheck 
    31583158 
    3159 context linestart # \n brown 
     3159context # \n brown 
    31603160    spellcheck 

Change History

comment:1 Changed 3 months ago by andrew_b

  • Component changed from mc-core to mcedit

comment:2 Changed 3 months ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8.32

comment:3 Changed 3 months ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset set to committed-master
  • Resolution set to fixed

Thanks!
Applied as [147f28ab24bf69a3465ae752f89da34ea0bf74b2].

comment:4 Changed 3 months ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.