Ticket #4518 (closed defect: fixed)

Opened 4 months ago

Last modified 3 months ago

cd to rar5 achives breaks with rar-7

Reported by: ctmp1 Owned by: andrew_b
Priority: major Milestone: 4.8.32
Component: mc-vfs Version: 4.8.30
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

Release of rar 7 breaks the detection of of rar version in urar vfs. Currently only rar5 and rar6 is recognized by mcrarfs_list(). Probably, all rar archives with versions higher than 4 should be handled by mcrar5fs_list()

Steps to reproduce:

  1. install rar 7 or unrar 7
  2. press "Enter" on rar5 archive

Various errors appear like:

1 1000 1002 0 00/00/00  ./                4582       732  15%                              1

Possible fix:

--- urar	2023-08-28 03:00:00.000000000 +0300
+++ urar.new	2024-01-13 16:25:56.396778971 +0300
@@ -113,7 +113,7 @@
 
 mcrarfs_list ()
 {
-    [ x$UNRAR_VERSION = x6 -o x$UNRAR_VERSION = x5 ] && mcrar5fs_list "$@" || mcrar4fs_list "$@"
+    [ x$UNRAR_VERSION \> x4 ] && mcrar5fs_list "$@" || mcrar4fs_list "$@"
 }
 
 mcrarfs_copyin ()

Attachments

mc_rar7.patch​ (333 bytes) - added by ctmp1 4 months ago.

Change History

Changed 4 months ago by ctmp1

comment:1 Changed 4 months ago by andrew_b

  • Component changed from mc-core to mc-vfs

comment:2 Changed 3 months ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.32

Branch: 4518_unrar7
changeset:5b7e64b1cf4f35e21774d074b349310670a86b2c

comment:3 Changed 3 months ago by zaytsev

  • Votes for changeset set to zaytsev

comment:4 Changed 3 months ago by andrew_b

  • Votes for changeset changed from zaytsev to zaytsev andrew_b
  • Branch state changed from on review to approved

comment:5 Changed 3 months ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from zaytsev andrew_b to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [c1832fd586361f9c5a62a77da0d6c4a693a9ac51].

comment:6 Changed 3 months ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.