Ticket #4462 (closed defect: fixed)
Build failed if ncurses used without --with-ncurses-includes= configure parameter
| Reported by: | karlson2k | Owned by: | andrew_b |
|---|---|---|---|
| Priority: | major | Milestone: | 4.8.30 |
| Component: | compilation | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
If ncurses location is not specified by configure parameters like '--with-ncurses-includes=/some/dir' then automatic detection at compiler/system default location is used in configure.
With automatic detection the header 'ncurses/term.h' is not checked therefore macro HAVE_NCURSES_TERM_H is not defined.
This leads to inclusion of system <term.h> which is not compatible with ncurses headers.
The simple fix is just addition of ncurses/term.h header detection to configure.
The suggested fix: https://github.com/MidnightCommander/mc/pull/186
Attachments
Change History
comment:1 Changed 11 months ago by andrew_b
- Status changed from new to accepted
- Owner set to andrew_b
- Component changed from mc-core to compilation
- Milestone changed from Future Releases to 4.8.30
comment:2 Changed 11 months ago by andrew_b
- Branch state changed from no branch to on review
Thanks for the patch!
Branch: 4462_ncurses_includes
changeset:1f732f0a140cb069d9477ef4c094330b7e6d2162
comment:3 Changed 11 months ago by andrew_b
- Votes for changeset set to andrew_b
- Branch state changed from on review to approved
comment:4 Changed 11 months ago by andrew_b
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: [5c9a145c3d76e560323e8e24c597fd8965af3099].
Note: See
TracTickets for help on using
tickets.
