comparison between pointer and zero character constant

[egmont]

gcc-7.2 caught this:

  CC       boxes.lo
boxes.c: In function ‘jobs_fill_listbox’:
boxes.c:431:22: warning: comparison between pointer and zero character constant [-Wpointer-compare]
     if (state_str[0] == '\0')
                      ^~
boxes.c:431:9: note: did you mean to dereference the pointer?
     if (state_str[0] == '\0')
         ^

It's indeed right, the code is buggy. It should be state_str[0][0].

[egmont]

... or maybe like this (see attached patch)?

(I haven't tried runtime, just compiled it :))

[andrew_b]

This is already fixed in 3780_cleanup: b2bbd326e0aa77df8aa48b4a1b4fd25bbbb7a40a.

[egmont]

Oops, sorry then :)