Ticket #2765 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

[ftp] Show directory sizes broken

Reported by: x905 Owned by: slavazanko
Priority: major Milestone: 4.8.3
Component: mc-vfs Version: 4.8.2
Keywords: Cc: krokous@…
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

Command "Show directory sizes" shows zero when executed on ftp

4.8.2-26-g3907f19

Change History

comment:1 Changed 4 years ago by krokous

  • Keywords regression added
  • Cc krokous@… added

I found out that the "show directory sizes" shows zero when done on .tgz archive (i.e. also VFS) and I suspect the cause for that bug is the same as the cause for this bug.

Using "git bisect" to find which commit introduced this bug resulted in this:

0aa10fd6cb5d2182aaa5a8614d355d85bb8b149b is the first bad commit
commit 0aa10fd6cb5d2182aaa5a8614d355d85bb8b149b
Author: Slava Zanko <slavazanko@…>
Date: Tue Sep 27 22:13:50 2011 +0300

Changed type of WPanel::cwd (char *) and WPanel::lwd (char *)

...to WPanel::cwd_vpath (vfs_path_tr *) and WPanel::lwd_vpath (vfs_path_t *).

Signed-off-by: Slava Zanko <slavazanko@…>

comment:2 Changed 4 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted

comment:3 Changed 4 years ago by slavazanko

  • Keywords stable-candidate added; regression removed
  • Blocking 2695 added
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.3

Created branch 2765_vfs_directory_sizes

Review, please.

comment:4 Changed 4 years ago by slavazanko

This ticket is relative to #2695 and should be applied to stable after merge of #2695

comment:5 Changed 4 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Version changed from master to 4.8.2

comment:6 Changed 4 years ago by angel_il

  • Votes for changeset changed from andrew_b to andrew_b angel_il
  • Branch state changed from on review to approved

comment:7 Changed 4 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b angel_il to committed-master
  • Resolution set to fixed

Merged to master: [117aa6715589397bbf2e1c8965a2a138c381eb17]

git log --pretty=oneline 461b3f7..117aa67
Last edited 4 years ago by andrew_b (previous) (diff)

comment:8 Changed 4 years ago by slavazanko

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Votes for changeset changed from committed-master to committed-master committed-stable
  • Blocking 2695 removed

Also merged to stable.

comment:9 Changed 4 years ago by slavazanko

  • Branch state changed from approved to merged
Note: See TracTickets for help on using tickets.