Ticket #2614 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Editor word completion should ignore the current word

Reported by: ply Owned by: slavazanko
Priority: major Milestone: 4.8.1
Component: mcedit Version: 4.8.0-pre2
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

Currently the completion considers the word the cursor is on as a possible completion, but this is quite annoying if the cursor is inside the word. Such completion effectively inserts the rest of the word one more time, so CamelCase becomes CamelCaseCase. If this is the only match, it completes automatically, which is even worse. The current word shouldn't be used for completion.

See patch.

Attachments

editcmd.c.diff (1.2 KB) - added by ply 5 years ago.

Change History

Changed 5 years ago by ply

comment:1 Changed 5 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted
  • Milestone changed from Future Releases to 4.8

comment:2 Changed 5 years ago by slavazanko

  • Keywords stable-candidate added
  • Branch state changed from no branch to on review

Created branch 2614_word_completion

Initial changeset: c804775bb9a93c61aacbe0186d96c016ae679922
Review, please.

fix: author of changeset

Last edited 5 years ago by angel_il (previous) (diff)

comment:3 Changed 5 years ago by andrew_b

Well, patch does not fully fix the problem.

Example. Open configure.ac. Find lines 16 and 17:

     16 AC_SUBST(LIBMC_VERSION)
     17 AC_SUBST(LIBMC_RELEASE)

Note: there are many 'AC_SUBST' words in the file.
Move cursor to the B letter in AC_SUBST word in some line. Press esc-tab. You get AC_SUBSTBST.

comment:4 Changed 5 years ago by slavazanko

Well, patch does not fully fix the problem.

Fixed. changeset:2306e89e55c526efb2dffe4a63197721cef05ec2

comment:5 Changed 5 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Component changed from mc-core to mcedit
  • Milestone changed from 4.8 to 4.8.0

comment:6 Changed 5 years ago by andrew_b

  • Milestone changed from 4.8.0 to 4.8.1

comment:7 Changed 5 years ago by slavazanko

  • Votes for changeset andrew_b deleted

Branch rebased to 4.7.5-stable

Also, new commit was added.

Review again, please.

comment:8 Changed 5 years ago by andrew_b

  • Votes for changeset set to andrew_b

comment:9 Changed 5 years ago by angel_il

  • Votes for changeset changed from andrew_b to andrew_b angel_il
  • Branch state changed from on review to approved

comment:10 Changed 5 years ago by slavazanko

  • Keywords stable-candidate removed
  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b angel_il to committed-master committed-stable
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to stable:

git log --pretty=oneline d33ae78..056200e

Rebased and merged to master:

git log --pretty=oneline 1f24672..87e6589
Last edited 4 years ago by angel_il (previous) (diff)

comment:11 Changed 5 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.