Ticket #2572 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Patchfs with filenames containing whitespaces

Reported by: storchaka Owned by: slavazanko
Priority: major Milestone: 4.8.0-pre1
Component: mc-vfs Version: 4.7.5
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: commited-master commited-stable

Description

Currently patchfs is not correctly work with filenames containing whitespaces. Followed patch partially resolve this issue (solution ported from patch utility). Solution is not perfect because of ambiguous diff syntax.

Attachments

patchfs-filename-whitespace.patch (1.8 KB) - added by storchaka 5 years ago.
example-u.diff (104 bytes) - added by storchaka 5 years ago.
Sample unified diff
example-c.diff (132 bytes) - added by storchaka 5 years ago.
Sample context diff

Change History

comment:1 Changed 5 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko

comment:2 Changed 5 years ago by slavazanko

  • Branch state changed from no branch to on review

Created branch 2572_patchfs_space_in_fnames

Initial changeset:a18f296e0e05ebaf6fbb258b60e9b85c91fccbe8

Review, please.

Changed 5 years ago by storchaka

Changed 5 years ago by storchaka

Sample unified diff

Changed 5 years ago by storchaka

Sample context diff

comment:3 Changed 5 years ago by angel_il

  • Votes for changeset set to angel_il

comment:4 Changed 5 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • Branch state changed from on review to approved

comment:5 Changed 5 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il slavazanko to commited-master
  • Branch state changed from approved to merged
  • Milestone changed from 4.8 to 4.8.0-pre1
  • Keywords stable-candidate added
  • Resolution set to fixed

comment:6 Changed 5 years ago by slavazanko

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Votes for changeset changed from commited-master to commited-master commited-stable

Cherry-picked in stable:

git log --pretty=oneline 50e62865a0..9e9b6cbdc
Note: See TracTickets for help on using tickets.