Ticket #231 (reopened enhancement)

Opened 7 years ago

Last modified 11 months ago

Initial Friendly Interactive SHell support

Reported by: me@… Owned by: slyfox
Priority: minor Milestone: Future Releases
Component: mc-core Version: master
Keywords: Cc: zaytsev, SanskritFritz, elpresidento@…, mooffie@…
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description (last modified by slyfox) (diff)

Here comes a patch to make fish (http://fishshell.org/) work together with MC. As I am not an MC user myself I'm not sure if there are things broken, but it is at least a start.

merged as changeset:1b5ae972bbdfe4aaa7f94b4248fc030c5319993c

Attachments

0001-Start-on-fish-Friendly-Interactive-SHell-support.2.patch (3.2 KB) - added by pekdon 7 years ago.
Patch for fish shell support

Change History

Changed 7 years ago by pekdon

Patch for fish shell support

comment:1 Changed 7 years ago by angel_il

  • Keywords fish removed
  • Milestone changed from 4.7 to 4.7.0-pre1

comment:2 Changed 7 years ago by slyfox

  • Keywords review vote-slyfox added

branch:231_bg_shell_fish_support
changeset:128160fef1d44ed8891c0e7e09b994cda3590ddf

Pushed in slightly (cosmetic) modified form.
Patch looks absolutely noninvasive, so no reason not to vote for it :]

comment:3 Changed 7 years ago by slyfox

  • Owner set to slyfox
  • Status changed from new to assigned

comment:4 Changed 7 years ago by angel_il

  • Keywords vote-angel_il added

comment:5 Changed 7 years ago by slavazanko

  • Keywords vote-slavazanko approved added; review removed

hm... I think, need to handle envirovement variable $fish_prompt_normal

I don't see correct prompt.

My test case:

$ export SHELL=/bin/fish
$ fish

slavaz@slavaz-nb /h/s> /path/to/test/mc

I see only '$' symbol as prompt. After pressing CTRL+O no subshel is running. Is I'm wrong or this bug?

comment:6 Changed 7 years ago by slavazanko

  • Keywords review added; vote-slavazanko approved removed

Ops, sorry. :)

comment:7 follow-up: ↓ 8 Changed 7 years ago by angel_il

maybe do this optional ?
--enable-fish

comment:8 in reply to: ↑ 7 Changed 7 years ago by slyfox

Replying to angel_il:

maybe do this optional ?
--enable-fish

For what purpose? What does new code break? Why do we need to uglify this tiny patch with more #ifdefs?

comment:9 Changed 7 years ago by angel_il

  • Keywords approved added

comment:10 Changed 7 years ago by slyfox

  • Keywords committed-master added; review vote-slyfox vote-angel_il approved removed
  • Status changed from assigned to testing
  • Resolution set to fixed
  • Description modified (diff)

Merged as-is. changeset:1b5ae972bbdfe4aaa7f94b4248fc030c5319993c

Nice shell prompt needs slightly more explorations.

comment:11 Changed 7 years ago by styx

  • Status changed from testing to closed

comment:12 Changed 6 years ago by zaytsev

  • Status changed from closed to reopened
  • severity set to no branch
  • Cc zaytsev, SanskritFritz added
  • Version changed from 4.6.2 to master
  • Milestone changed from 4.7.0-pre1 to 4.8
  • Keywords committed-master removed
  • Resolution fixed deleted

comment:13 Changed 6 years ago by zaytsev

Fish support is broken:

http://bbs.archlinux.org/viewtopic.php?id=96278

mc takes ages to start and starts with no subshell.

comment:14 Changed 5 years ago by elpresidento

  • Branch state set to no branch

I solved it with simple script and I run this script istead of mc:

#!/bin/bash
SHELL=/bin/bash
mc
SHELL=/bin/fish

comment:15 Changed 5 years ago by elpresidento

  • Cc elpresidento@… added

comment:16 Changed 14 months ago by mooffie

  • Cc mooffie@… added

comment:17 Changed 11 months ago by andrew_b

  • Milestone changed from 4.8 to Future Releases
Note: See TracTickets for help on using tickets.