Ticket #2177 (closed enhancement: fixed)

Opened 6 years ago

Last modified 5 years ago

mcdiff shortcut

Reported by: gotar Owned by: slavazanko
Priority: minor Milestone: 4.7.5
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: commited-master

Description

mc.keymap defines:

CmdCompareDirs = d
CmdDiffView = ctrl-y

it would be more logical to have CmdDiffView under ctrl-d xmap.

Change History

comment:1 Changed 6 years ago by slavazanko

Just create mc.keybind.gotar and attach to this ticket ;)

comment:2 Changed 6 years ago by gotar

It doesn't make any sense to create alternate keymap for just one binding. I'd prefer default to be changed to something better as it's still new feature.

comment:3 follow-up: ↓ 4 Changed 6 years ago by andrew_b

Actually, the c-x c-y shortcut is already used for a long time. I think this thicket should be closed as wontfix.

comment:4 in reply to: ↑ 3 ; follow-up: ↓ 11 Changed 6 years ago by gotar

I don't share your opinion:

  1. mcdiff exists only in development branch, so according to your own statement from http://www.midnight-commander.org/ticket/2305#comment:6 (and 3 above) this is not an argument,
  1. even if some of you are so attached to existing shortcut, it's possible to reserve second keystroke to the CmdDiffView.

All I'd like to get are fine working defaults for next stable release, so if you think ctrl-y is logical (I don't even know a language wich has 'y' in 'difference') please close this, as personally I don't have any problems in changing mc.keymap locally.

comment:5 Changed 6 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko

comment:6 Changed 6 years ago by slavazanko

  • Version changed from version not selected to master
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.5

Created branch 2177_change_cmddiff_shorcut (parent: master)
Initial changeset:a345d9ec68728f90fea6968c73cd4c45f444f9bc

Review, please.

comment:7 Changed 6 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • Component changed from mc-config-ini to mc-core

Ok. My vote here.

comment:8 Changed 6 years ago by angel_il

  • Votes for changeset changed from andrew_b to andrew_b angel_il
  • severity changed from on review to approved

comment:9 Changed 6 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b angel_il to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master; changeset: 8f4ccc828621ad96488894e2b2c16e409702fe78

comment:10 Changed 6 years ago by slavazanko

  • Status changed from testing to closed

comment:11 in reply to: ↑ 4 Changed 5 years ago by dborca

Replying to gotar:

All I'd like to get are fine working defaults for next stable release, so if you think ctrl-y is logical (I don't even know a language wich has 'y' in 'difference') please close this, as personally I don't have any problems in changing mc.keymap locally.

I don't know a language wich has '?' in 'Find File', either. But that's not the point. The point is that you don't know many languages. Like, "man diff", for example:

-y --side-by-side

Output in two columns.

But don't mind me. Feel free to shuffle a random number of shortcuts in each release.

Note: See TracTickets for help on using tickets.