Ticket #2127 (closed enhancement: fixed)

Opened 7 years ago

Last modified 7 years ago

[PATCH] [Syntax] UPDATED: file extension for "sh"

Reported by: zaytsev Owned by: zaytsev
Priority: trivial Milestone: 4.7.2
Component: mcedit Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description (last modified by andrew_b) (diff)

http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=502196

From: Michelle Konzack <linux4michelle@tamay-dogan.net>
To: BTS <submit@bugs.debian.org>
Subject: [Syntax] UPDATED: file extension for "sh"
Date: Tue, 14 Oct 2008 13:06:47 +0200
[Message part 1 (text/plain, inline)]
Package: mc
Severity: wishlist
Hello Winnie,
I find it realy annoying, if I put something in my BaSH configs and have
NO syntax hilighting so I have changed the line from
file ..\*\\.sh$ Shell\sScript ^#!\s\*/(.\*/|usr/bin/env\s)([a-z]?|ba|pdk)sh
include sh.syntax
to
file .\*(bash_completion|profile|\\.(sh|bash_login|bash_profile|bash_logout|bash_aliases|bash_exports|bash_history|bash_userstuff|bashrc|profile))$ Shell\sScript ^#!\s\*/(.\*/|usr/bin/env\s)([a-z]?|ba|pdk)sh
include sh.syntax
which now coloriser my BaSH configs nicely...
(See attached screenshot)
Thanks, Greetings and nice Day/Evening
    Michelle Konzack
    Systemadministrator
    24V Electronic Engineer
    Tamay Dogan Network
    Debian GNU/Linux Consultant

Attachments

0001-Ticket-2127.patch (1.1 KB) - added by zaytsev 7 years ago.

Change History

Changed 7 years ago by zaytsev

comment:1 Changed 7 years ago by zaytsev

  • severity changed from no branch to on review

Branch: 2127_sh_ext (parent: master)
Changeset: 66ab789e4c6424899baa4698d20b5560dd3a36c9

comment:2 Changed 7 years ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev

comment:3 Changed 7 years ago by andrew_b

  • Component changed from mc-core to mcedit

comment:4 Changed 7 years ago by andrew_b

  • Description modified (diff)

I think, .bash_history is not a shell script. :)

comment:5 Changed 7 years ago by zaytsev

  • Keywords stable-candidate added

This is arguable :) my .bash_history, for instance is a huge shell script, because it contains nothing else, but commands I executed for bash ;)

comment:6 Changed 7 years ago by andrew_b

  • Votes for changeset set to andrew_b

comment:7 Changed 7 years ago by zaytsev

  • Votes for changeset changed from andrew_b to andrew_b zaytsev

comment:8 Changed 7 years ago by zaytsev

  • Votes for changeset andrew_b zaytsev deleted
  • severity changed from on review to approved

comment:9 Changed 7 years ago by zaytsev

  • Status changed from accepted to testing
  • Votes for changeset set to commited-master
  • Resolution set to fixed

Merged to master, changeset: f946551dd404b4690bf9fc2b5351fbbe667f0a29 .

comment:10 Changed 7 years ago by zaytsev

  • severity changed from approved to merged

comment:11 Changed 7 years ago by zaytsev

  • Status changed from testing to closed
  • Keywords stable-candidate removed
  • Votes for changeset changed from commited-master to commited-master commited-stable

Cherry-picked to 4.7.0-stable, changeset: 1824a59f5632893d5f4dc445ef9f4d24a92630b5 .

comment:12 Changed 7 years ago by andrew_b

What about Ossi's note about bash_userstuff: http://groups.google.com/group/mc-commits/msg/b0342245a16055c8

comment:13 Changed 7 years ago by zaytsev

Hi!

I don't read this list (actually, I feel it should be made read-only so that all of the discussion happens on Trac and the list serves informational purpose only and no important points get lost), but his point is valid. However, I have a habit of never modifying the RegExps? that work. If he wants to make a "better" RegExp? I will be the first to vote for it.

Z.

comment:14 Changed 7 years ago by andrew_b

OK, regexp is valid and works. But what is bash_userstuff, though? I think, we should remove it.

comment:15 Changed 7 years ago by zaytsev

I don't mind. I guess this was OP's weird name to separate common things from .bashrc and .profile. Shall we/I use direct commits on top of the tree or you will take care of it?

comment:16 Changed 7 years ago by andrew_b

For master, we/you can use 2097_cleanup_master branch. For 4.7.0-stable there is no such branch, therefore direct commit can be used.

comment:17 Changed 7 years ago by zaytsev

Please checkout changeset:59a1440e99cff54ec9fc85c82bfd207da2d0500f . I can later cherrypick it to stable.

comment:18 Changed 7 years ago by zaytsev

Done, thanks.

Note: See TracTickets for help on using tickets.