Ticket #2107 (closed defect: fixed)

Opened 6 years ago

Last modified 5 years ago

Turning on wrap mode does not scroll left the file view

Reported by: wwp Owned by: andrew_b
Priority: minor Milestone: 4.7.2
Component: mcview Version: 4.7.1
Keywords: wrap viewer Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

It seems I can't scroll view to the left when I:

  • open a text file (view mode), be in UnWrap? mode
  • find a long line (longer than the window width)
  • scroll to the right w/ the right cursor key so that you see the rightest chars of the long line
  • switch ON wrap mode, view window is not reset to the lefter column
  • press left key to scroll left to the beginning of line -> doesn't work

The problem could be that when switching to wrap ON the scrollable window doesn't automatically shift to the left - if it was doing it, the user would not want to scroll left to see what it should not.

It's my Fedora 11's mc:

$ rpm -q mc
mc-4.7.1-2.53.gd07e719.fc11.i586

$ mc --version
GNU Midnight Commander 4.7.1-53-gd07e719
Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish, smbfs
With builtin Editor
Using system-installed S-Lang library with terminfo database
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With internationalization support
With multiple codepages support
Data types: char 8 int 32 long 32 void * 32 off_t 64 ecs_char 8

Change History

comment:1 Changed 6 years ago by angel_il

  • Status changed from new to accepted
  • Owner set to angel_il
  • Version changed from version not selected to master

comment:2 Changed 6 years ago by andrew_b

  • Owner changed from angel_il to andrew_b
  • Version changed from master to 4.7.1
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.2

Created 2107_viewer_wrap_scroll_left_right branch. Parent branch is master.
Initial changeset:79a91164c3cb4fd9d0fc7287aa20b38e7206ebe6

Also some optimization of viewer was performed in child commits.

Review please.

comment:3 Changed 6 years ago by angel_il

  • Votes for changeset set to angel_il

comment:4 Changed 6 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:5 Changed 6 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il slavazanko to commited-master
  • Resolution set to fixed

Merged to master.
changeset:79a91164c3cb4fd9d0fc7287aa20b38e7206ebe6

git log --pretty=oneline fa53033..00ddfc0

comment:6 Changed 6 years ago by andrew_b

  • Status changed from testing to closed
  • Keywords stable-candidate added
  • severity changed from approved to merged

comment:7 Changed 5 years ago by andrew_b

  • Keywords stable-candidate removed
Note: See TracTickets for help on using tickets.