Ticket #2028 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

in-hexC-missing-check-and-g_free

Reported by: vit_r Owned by: andrew_b
Priority: major Milestone: 4.7.1
Component: mc-search Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description (last modified by andrew_b) (diff)

lib/search/hex.c
in mc_searchhex_translate_to_regex ():

  • missing check of g_strdup_printf() return
  • missing g_free (tmp_str);

Attachments

2028-in-hexC-missing-retchecks-and-g_free.patch (1.7 KB) - added by vit_r 7 years ago.

Change History

comment:1 follow-up: ↓ 2 Changed 7 years ago by andrew_b

  • Description modified (diff)

Patch contains memory leaks in lines 66 and 78.

Changed 7 years ago by vit_r

comment:2 in reply to: ↑ 1 Changed 7 years ago by vit_r

Replying to andrew_b:

Patch contains memory leaks in lines 66 and 78.

Thanks
My fall
Hope You meant this (replaced patch)

comment:3 Changed 7 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • severity changed from no branch to on review

Cretaed 2028_hex_search_memleak branch. Parent branch is master.
changeset:b732b6f07f2e5756003e8974499a880bd75cd2d8

comment:4 Changed 7 years ago by andrew_b

  • Priority changed from trivial to major

comment:5 Changed 7 years ago by angel_il

  • Votes for changeset set to angel_il

comment:6 Changed 7 years ago by andrew_b

  • Description modified (diff)

Fixed comment and rebased to current master.
changeset:2dab612a897a7bf23de1592c9dec68025cf2de01

comment:7 Changed 7 years ago by andrew_b

  • Description modified (diff)

comment:8 Changed 7 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:9 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il slavazanko to commited-master commited-stable
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset:4451e07fab0e32182c7057a12e7b210f397414e7

Cherry-picked to 4.7.0-stable.
changeste:790946f9cad5cd90d7582f9a3445e192cf40831b

comment:10 Changed 7 years ago by andrew_b

  • Status changed from testing to closed

Sorry for typo.

Cherry-picked to 4.7.0-stable.
changeset:790946f9cad5cd90d7582f9a3445e192cf40831b

Note: See TracTickets for help on using tickets.