Ticket #1774 (closed defect: fixed)

Opened 7 years ago

Last modified 6 years ago

Various build fixups (missing includes, name clashes, ...)

Reported by: metux Owned by: metux
Priority: blocker Milestone: 4.7.0
Component: mc-core Version: 4.7.0-pre4
Keywords: build,-Werror,includes,name-conflicts Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by metux) (diff)

There are several unclean things which break build in -Werror mode, eg: char* vs const char* mixups, missing includes, conflicting variable names, etc.

branch:1774_build_cleanups
changeset:4a1e9c124c6028307be260bb8d2e0c0e516a2c1a

Change History

comment:1 Changed 7 years ago by metux

  • Owner set to metux
  • Status changed from new to accepted
  • severity changed from no branch to on review

comment:2 Changed 7 years ago by metux

  • Priority changed from major to blocker

comment:3 Changed 7 years ago by slavazanko

  • Votes for changeset set to slavazanko

Branch for this ticket: 1774_build_cleanups

Looks good.

comment:4 Changed 7 years ago by slavazanko

  • Milestone changed from 4.7 to 4.7.0

comment:5 Changed 7 years ago by slavazanko

  • Votes for changeset slavazanko deleted

My latest correct changeset:f91d4aa1ac6e07ecb10b47abd7e642619b749036

Changed include 'glib.h' to 'global.h' besause global.h file have some things for backward compability with glib (eg. including 'glibcompat.h')

Review.

comment:6 Changed 7 years ago by slavazanko

Also, branch rebased for more WorkingGuideLines-complicant

Added Ticket number in first commit of branch.

Initial changeset:083d3546a6979c81e2a2a728b4b832fa6e2ed144

comment:7 Changed 7 years ago by metux

  • Description modified (diff)

Rebased to current master

comment:8 Changed 7 years ago by iNode

  • Votes for changeset set to iNode

comment:9 Changed 7 years ago by slavazanko

  • Votes for changeset changed from iNode to iNode slavazanko
  • severity changed from on review to approved

comment:10 Changed 7 years ago by metux

  • severity changed from approved to merged
  • Description modified (diff)

rebased and merged into master

comment:11 Changed 7 years ago by metux

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:12 Changed 7 years ago by andrew_b

  • Status changed from testing to closed
  • Votes for changeset changed from iNode slavazanko to commited-master
git log --pretty=oneline d740efc...de4e40d
Note: See TracTickets for help on using tickets.