Ticket #1707 (closed defect: invalid)

Opened 7 years ago

Last modified 7 years ago

search dialog wrong behavior

Reported by: x905 Owned by:
Priority: major Milestone: 4.7
Component: mc-core Version: 4.7.0-pre3
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

its wrong what "Find File" dialog saves previous searched strings in _editor_ and paste this in field "Content" - its must be "checkboxed" in settings for this behavior
moreover - "Find File" dialog cant save empty "Content" filed - i want search files, not content but "Content" filed always have some string, that i search before

Change History

comment:1 in reply to: ↑ description Changed 7 years ago by andrew_b

Replying to x905:

its wrong what "Find File" dialog saves previous searched strings in _editor_ and paste this in field "Content" - its must be "checkboxed" in settings for this behavior

Search fields in editor, in viewer and in find file ('Content') have shared history. It's a feature.

moreover - "Find File" dialog cant save empty "Content" filed

Already fixed in #1662. Please try current master branch.

comment:2 follow-up: ↓ 3 Changed 7 years ago by x905

imagine: i search a file with some mask without content (just filename), then i edit or view some another file, using search box, and then i want search again some filename without a content (again just filename) - is field "content" be filled ?
i want not

comment:3 in reply to: ↑ 2 Changed 7 years ago by andrew_b

Replying to x905:

is field "content" be filled ?

No. State of 'Content' field (empty or not empty) is kept between find file sessions.

comment:4 Changed 7 years ago by slavazanko

x905, Content will filled by last entered value. If last entered value is (empty string), then you'll always search acros files only, not in files content. Is this behavior like to you?

comment:5 Changed 7 years ago by slavazanko

If last entered value is (empty string)

Must be:
If last entered value is "" (empty string)

Sorry, WikiFormatting... :)

comment:6 Changed 7 years ago by x905

if i search for files with empty string in "Content", then regardless of that i search in editor or viewer, this field must be empty

comment:7 Changed 7 years ago by andrew_b

Could you try current master?

comment:8 Changed 7 years ago by x905

ok, i try it latter today
as i think this command: git clone http://repo.or.cz/r/midnight-commander.git ?

comment:9 follow-up: ↓ 10 Changed 7 years ago by slavazanko

as i think this command: git clone http://repo.or.cz/r/midnight-commander.git ?

Yes, this is a mirror of repo.

You may clone directly:

git clone git://midnight-commander.org/git/mc.git

Or, if you behind a firewall:

git clone http://git.midnight-commander.org/mc.git

This is once-made operation. In future, if you'll need for updates of repo, you shoud run:

git pull
git fetch --tags (this command need to run after release)

comment:10 in reply to: ↑ 9 Changed 7 years ago by andrew_b

Replying to slavazanko:

This is once-made operation. In future, if you'll need for updates of repo, you shoud run:

git pull
git fetch --tags (this command need to run after release)

HTTP is not best way for that. pull via HTTP is equivalent to clone.

comment:11 Changed 7 years ago by x905

1st: git clone http://git.midnight-commander.org/mc.git && git log show only last commit at Date: Mon Jun 22 14:12:19 2009 +0000 - why?
2nd: find file dialog now works as expected, now i try this build (and latter)
3d: http://www.midnight-commander.org/ticket/1718

comment:12 Changed 7 years ago by x905

forget: git clone git://midnight-commander.org/git/mc.git - works ok

comment:13 Changed 7 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to invalid
Note: See TracTickets for help on using tickets.