Changes between Version 3 and Version 4 of WorkingGuideLines


Ignore:
Timestamp:
01/09/09 13:02:55 (15 years ago)
Author:
slavazanko
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • WorkingGuideLines

    v3 v4  
    2929   * introduces this code new bugs? 
    3030 * If you're fine with this patch add a keyword: "vote-<yourloginname>", but please let review in place. In case the patch is not okay, you can choose if it simply needs some cleanup (e.g. mixing Space vs Tabs for intending, ...), then remove the review keyword and add "cleanup" as keyword, or if the patch is broken or hackish.. then replace "review" with "rework".  
    31  * Currently two "vote-<yourloginname>" are needed in order to get a patch into the parent branch (either mc-4.6 or master). If you are the second one which have successfully reviewed this patch then also add a "accepted" keyword to the keywords list. 
     31 * Currently two "vote-<yourloginname>" are needed in order to get a patch into the parent branch (either mc-4.6 or master). If you are the second one which have successfully reviewed this patch then also add a "approved" keyword to the keywords list. 
    3232 
    3333== Applying Patch Guidelines ==