Ticket #64 (closed task: fixed)

Opened 8 years ago

Last modified 2 years ago

Dialog sizes must be i18n-friendly

Reported by: bilboq Owned by: andrew_b
Priority: major Milestone: 4.8.7
Component: mc-core Version: master
Keywords: Cc: tux@…
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description (last modified by ossi) (diff)

Original: http://savannah.gnu.org/bugs/?19344

Submitted by:Martin Petricek <bilboq>Submitted on:Mon 19 Mar 2007 04:15:14 PM UTC
Category:Screen outputSeverity:3 - Normal
Status:NonePrivacy:Public
Assigned to:NoneOpen/Closed:Open
Release:current (CVS or snapshot)Operating System:GNU/Linux

Original submission:

Size of dialog to select listing mode [(Left|Right) -> Listing mode]
is hardcoded to 45 characters (or actually more if translated 
strings are longer).

However, with this default width, "User defined" string is often not
shown entirely and you have to scroll to see it.

I have created and attached patch, that will widen the dialog by up 
to 15 characters, if size of the screen allows it (dialog never 
grows wider than width of console).

Maybe similar modification could be done also to other dialogs? (not
 sure which of them can benefit from being wider if possible)

Attachments

boxsize.patch (1.8 KB) - added by slavazanko 8 years ago.
added by bilboq

Change History

Changed 8 years ago by slavazanko

added by bilboq

comment:1 Changed 7 years ago by ossi

iirc, this patch was discussed and rejected in the current form.

however, it is true that non-use of available screen space is a pervasive problem in mc. for example, the copy & rename dialogs will not grow, thus truncating file names even if there would be room to display each name three times.

comment:2 Changed 7 years ago by styx

  • Milestone set to future releases

comment:3 Changed 7 years ago by bilbo

  • Cc tux@… added
  • severity set to no branch

comment:4 Changed 7 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b

comment:5 Changed 7 years ago by andrew_b

  • Blocked By 1556, 1560 added
  • Summary changed from savannah: Listing mode dialog is too small (+patch to fix it) to Dialog sizes must be i18n-friendly

comment:6 Changed 7 years ago by andrew_b

  • Version set to master
  • Type changed from enhancement to task

comment:7 Changed 7 years ago by andrew_b

  • Blocked By 1556 removed

(In #1556) Merged to master.
changeset:434ebd3780d400cffa274b96ea29614e668f58fc

All other dialogs will be fixed in #64.

comment:8 Changed 7 years ago by andrew_b

  • Blocked By 1560 removed

comment:9 Changed 7 years ago by andrew_b

  • Milestone changed from Future Releases to 4.7

Created 64_dlg_i18n_friendly branch. Parent branch: master.
Initial changeset:22f0fb0e39715fcb5ad7af6101b48d9b4a1360ba

comment:10 Changed 5 years ago by gms

Hmm, I've seen an MC build where this problem was resolved by increasing dialogs size verticaly and composing controls in 2 or more lines

comment:11 Changed 5 years ago by andrew_b

  • Milestone changed from 4.7 to 4.8

comment:12 Changed 4 years ago by andrew_b

  • Branch state set to no branch
  • Milestone changed from 4.8 to Future Releases

comment:13 Changed 4 years ago by andrew_b

  • Blocked By 2919 added

comment:14 Changed 4 years ago by andrew_b

  • Blocked By 2919 removed

comment:15 Changed 4 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Milestone changed from Future Releases to 4.8.7

Implemented as part of #2919.

comment:16 Changed 4 years ago by andrew_b

  • Status changed from testing to closed

comment:17 Changed 2 years ago by ossi

  • Description modified (diff)
  • Reporter changed from slavazanko to bilboq
Note: See TracTickets for help on using tickets.