Ticket #403 (closed enhancement: fixed)

Opened 7 years ago

Last modified 7 years ago

version.sh fixes

Reported by: ossi Owned by:
Priority: minor Milestone: 4.7
Component: mc-core Version: master
Keywords: committed-master Cc:
Blocked By: Blocking: #411
Branch state: Votes for changeset:

Description (last modified by slyfox) (diff)

Attachments

0001-remove-useless-commands-which-also-happen-to-be-bash.patch (761 bytes) - added by ossi 7 years ago.
0002-remove-bashism.patch (531 bytes) - added by ossi 7 years ago.
0003-more-elegant-extraction-of-old-version.patch (834 bytes) - added by ossi 7 years ago.
0004-fix-typo.patch (723 bytes) - added by ossi 7 years ago.
0001-don-t-suppress-error-messages-from-git-availability-.patch (649 bytes) - added by ossi 7 years ago.
replace previous 0002
0002-fix-bashisms.patch (868 bytes) - added by ossi 7 years ago.
replace first 0001

Change History

Changed 7 years ago by ossi

Changed 7 years ago by ossi

Changed 7 years ago by ossi

comment:1 follow-ups: ↓ 3 ↓ 4 Changed 7 years ago by slyfox

0001-remove-useless-commands-which-also-happen-to-be-bash.patch

All patches look good except the first. It seems to break out-of-tree build. version.h must be updated in source tree even if configure is ran in another directory.

--git-dir might be needed

Mind to try 'git send-email' to mc-bugs@ as a followup to #403 ?
(Message-ID: <042.8aa6aaeb3f2833074e5b63f4e6b7dab8@…>)

comment:2 Changed 7 years ago by slyfox

--git-dir might be needed

or plain old_pwd="$PWD"; cd "${top_src_dir}"; ... cd "$old_pwd"

comment:3 in reply to: ↑ 1 Changed 7 years ago by iNode

About first patch:
pushd and popd does not work in zsh, maybe just remember pwd and return when you need?

comment:4 in reply to: ↑ 1 Changed 7 years ago by ossi

Replying to slyfox:

It seems to break out-of-tree build. version.h must be updated in source tree even if configure is ran in another directory.

whoops, the directory name "maint" triggered an "irrelevant for usual builds" switch in me.

--git-dir might be needed

indeed. patches following ...

Mind to try 'git send-email' to mc-bugs@ as a followup to #403 ?

i miss the point of the exercise ...

Changed 7 years ago by ossi

replace previous 0002

Changed 7 years ago by ossi

replace first 0001

comment:5 Changed 7 years ago by slyfox

  • Keywords review added

Pulled all patches and fixed actual version.h regeneration.
Added forced version.h generation in autogen.sh to avoid double
./configure start in clean envoronment (related to #411)

Branch: 403_versioning_cleanup
Start changeset:9a5c9cbc8898a80a82705aacc5be9c5866722b35
Tip changeset:eea108377d76d7855c25270c2551019098f46070
{{
git log 3337c39..eea10837
}}

comment:6 Changed 7 years ago by slyfox

  • Blocking 411 added

(In #411) #403 touches this issue in some places:

  • non-bash fixes
  • version.h pregeneration

comment:7 Changed 7 years ago by iNode

  • Keywords vote-iNode added

comment:8 Changed 7 years ago by slavazanko

  • Keywords vote-slavazanko added

Looks good.

comment:9 Changed 7 years ago by slavazanko

  • Keywords approved added; review removed

comment:10 Changed 7 years ago by slyfox

  • Status changed from new to closed
  • Keywords committed-master added; vote-iNode vote-slavazanko approved removed
  • Resolution set to fixed
  • Description modified (diff)
Note: See TracTickets for help on using tickets.