Ticket #387 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

find file crashes

Reported by: ossi Owned by: andrew_b
Priority: major Milestone: 4.7
Component: mc-core Version: master
Keywords: commited-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

Program received signal SIGSEGV, Segmentation fault.
(gdb) where full
#0 find_parameters (start_dir=0xafcdfa78, pattern=0xafcdfa74,

content=0xafcdfa70) at find.c:362

return_value = <value optimized out>
temp_dir = <value optimized out>
recursively_cbox = (WCheck *) 0x9796d28
file_regexp_cbox = (WCheck *) 0x9796d68
skip_hidden_cbox = (WCheck *) 0x9796f08
case_label = 0x80cab6e "case &Sensitive"
recurs_label = 0x80cab5c "&Find recursively"
skip_hidden_label = 0x80cab4f "S&kip hidden"
regexp_label = 0x80cab3b "&Regular expression"
file_regexp_label = 0x80cab3c "Regular expression"
in_contents = 0x97ac180 "logout"
in_start_dir = 0x97971f8 "."
in_start_name = 0x97aac80 "*"

#1 0x0806fcff in do_find () at find.c:1146

start_dir = 0x0
pattern = 0x0
content = 0x979b3b0 "logout"
filename = 0x8076a80 "ÉÃU\211å¡ì\205\021\b\200$þ¡Üz\016\b\205Àt\004\200$þ]ÃU\211åÇ\005d\230\016\b\001"
dirname = 0xafcdfa88 "\230úͯ~{\a\b\200sx\t\200sx\tÈúͯuo\006\b\200sx\t\n"
dir_and_file_set = 0

#2 0x08077b7e in midnight_callback (h=0x9787380, msg=DLG_UNHANDLED_KEY,

parm=8255) at main.c:1615

i = 159039872

#3 0x08066f75 in dlg_key_event (h=0x9787380, d_key=8255) at dialog.c:675

handled = <value optimized out>

#4 0x0806706f in frontend_run_dlg (h=0x9787380) at dialog.c:806

d_key = 159039872
event = {buttons = 240 'ð', modifiers = 127 '\177', vc = 2060,

dx = -1272, dy = -20531, x = -1, y = 2054, type = 158888832, clicks = 0,
margin = 0, wdx = -28088, wdy = 2421}

(gdb) bt
#5 0x080670ac in run_dlg (h=0x9787380) at dialog.c:821
#6 0x08077d64 in setup_panels_and_run_mc () at main.c:1704
#7 0x080780b8 in do_nc () at main.c:1776
#8 0x08078302 in main (argc=Cannot access memory at address 0x0
) at main.c:2268

the file & dir names in frame #1 seem bogus.

valgrind says:

==29861== Invalid read of size 4
==29861== at 0x806FAA2: find_parameters (find.c:362)
==29861== by 0x806FCFE: do_find (find.c:1146)
==29861== by 0x8077B7D: midnight_callback (main.c:1615)
==29861== by 0x8066F74: dlg_key_event (dialog.c:675)
==29861== by 0x806706E: frontend_run_dlg (dialog.c:806)
==29861== by 0x80670AB: run_dlg (dialog.c:821)
==29861== by 0x8077D63: setup_panels_and_run_mc (main.c:1704)
==29861== by 0x80780B7: do_nc (main.c:1776)
==29861== by 0x8078301: main (main.c:2268)
==29861== Address 0x2c is not stack'd, malloc'd or (recently) free'd
==29861==.
==29861== Process terminating with default action of signal 11 (SIGSEGV)
==29861== Access not within mapped region at address 0x2C
==29861== at 0x806FAA2: find_parameters (find.c:362)
==29861== by 0x806FCFE: do_find (find.c:1146)
==29861== by 0x8077B7D: midnight_callback (main.c:1615)
==29861== by 0x8066F74: dlg_key_event (dialog.c:675)
==29861== by 0x806706E: frontend_run_dlg (dialog.c:806)
==29861== by 0x80670AB: run_dlg (dialog.c:821)
==29861== by 0x8077D63: setup_panels_and_run_mc (main.c:1704)
==29861== by 0x80780B7: do_nc (main.c:1776)
==29861== by 0x8078301: main (main.c:2268)

Change History

comment:1 Changed 7 years ago by andrew_b

  • Version changed from 4.6.2 to master

Matched to comment:ticket:370:12

changeset:17343149d60c291281dcdaa182a864fbec6dd432 not totally fixes the usage of 'All charsets' related widgets.

comment:2 Changed 7 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to assigned
  • Keywords review added

387_disable_charset_findfile_segfault branch is created. Parent branch: master.
Initial changeset:dd319ef92e5d71e60c7742e875b5e50bbca996e2

comment:3 Changed 7 years ago by slavazanko

  • Keywords vote-slavazanko added

Vote here

comment:4 Changed 7 years ago by slyfox

  • Keywords vote-slyfox approved added; review removed

comment:5 Changed 7 years ago by slyfox

  • Status changed from assigned to testing
  • Keywords commited-master added; vote-slavazanko vote-slyfox approved removed
  • Resolution set to fixed

merged to master:
start changeset:1ee1c9cea24049e2ce9b8bcf89a9d7d934974eb9
end changeset:dd319ef92e5d71e60c7742e875b5e50bbca996e2

git log --pretty=oneline 3708dd2..dd319ef

comment:6 Changed 7 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.