Ticket #38 (closed defect: fixed)

Opened 7 years ago

Last modified 2 years ago

savannah: C-x i (info panel) returns to wrong directory

Reported by: ptsekov Owned by: andrew_b
Priority: major Milestone: 4.7.0-pre4
Component: mc-core Version: 4.7.0-pre3
Keywords: Cc: imdagger@…, gotar@…
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description (last modified by ossi) (diff)

Original: http://savannah.gnu.org/bugs/?16008

Submitted by:Pavel Tsekov <ptsekov>Submitted on:Mon 06 Mar 2006 07:28:41 AM UTC
Category:CoreSeverity:3 - Normal
Status:ConfirmedPrivacy:Public
Assigned to:NoneOpen/Closed:Open
Release:4.6.0Operating System:All

Original submission:

This bug report was originally submitted to the developers mailing list:

Using MC 4.6.0
GNU Midnight Commander 4.6.0
Virtual File System: tarfs, extfs, cpiofs, ftpfs, fish, smbfs
With builtin Editor
Using system-installed S-Lang library with terminfo database
With subshell support as default
With support for background operations
With mouse support on xterm and Linux console
With support for X11 events
With internationalization support
With multiple codepages support

When viewing two file lists, if user presses C-x i for info on
a panel's directory or file, the info pops up correctly in the
other panel. However, when the user closes the info screen, the
directory of the current panel is shown -- NOT the directory
which was being viewed before the info panel appeared.

Sorry if this is confusing. Let me illustrate:

Left Right
\ \usr\bin

User is in left panel
Presses C-x i (or selects Info from the Right Panel menu)
Info panel appears in Right panel
User presses C-x i again to toggle info off
(or selects listing mode from Right Panel menu)
Right directory panel now shows \, not \usr\bin

IMO, after info is closed, whatever was in the panel should be 
restored. 

Attachments

right_switch_mode.diff (4.4 KB) - added by IMDagger 7 years ago.
additional.diff (727 bytes) - added by IMDagger 7 years ago.
Additional for previous patch, fix nonlocal path
maxpath.diff (351 bytes) - added by IMDagger 7 years ago.
Not critical, but all use MC_MAXPATHLENGTH (that usually is MAXPATHLENGTH)
saved_path.patch (2.1 KB) - added by IMDagger 7 years ago.
Fixed problem with saving path into panels.ini

Change History

comment:1 Changed 7 years ago by styx

  • Milestone set to future releases

comment:2 Changed 7 years ago by angel_il

  • severity set to no branch
  • Description modified (diff)

comment:3 Changed 7 years ago by IMDagger

  • Cc imdagger@… added

comment:4 Changed 7 years ago by IMDagger

Work not only with C-x i, but with tree mode and quick view too. I tested it, but may be it need in more deep testing :-/.

Changed 7 years ago by IMDagger

comment:5 Changed 7 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Version set to 4.6.1
  • Milestone changed from future releases to 4.7.0-pre2

comment:6 Changed 7 years ago by andrew_b

  • Votes for changeset set to andrew_b
  • severity changed from no branch to on review

Created branch 38_info_panel_return_to_wrong_dir. Parent branch: master.
changeset:69c0d7c4f4af8a796f6ba2d8d10f9f81308f88da

Changed 7 years ago by IMDagger

Additional for previous patch, fix nonlocal path

comment:7 Changed 7 years ago by andrew_b

Squashed both patches to single commit: changeset:a1a526e5a79bc994c7cb9486d7b1ebbf0f6d8128

comment:8 Changed 7 years ago by slavazanko

  • Votes for changeset changed from andrew_b to andrew_b slavazanko
  • severity changed from on review to approved

comment:9 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b slavazanko to commited-master
  • Resolution set to fixed

comment:10 Changed 7 years ago by andrew_b

  • Status changed from testing to closed

Changed 7 years ago by IMDagger

Not critical, but all use MC_MAXPATHLENGTH (that usually is MAXPATHLENGTH)

comment:11 follow-up: ↓ 12 Changed 7 years ago by IMDagger

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:12 in reply to: ↑ 11 Changed 7 years ago by IMDagger

Replying to IMDagger:
ohh.. :) of course, MAXPATHLEN :)

comment:13 Changed 7 years ago by andrew_b

  • Votes for changeset changed from commited-master to andrew_b
  • Version changed from 4.6.1 to master
  • severity changed from approved to on review

Created branch 38_maxpathlen. Parent branch: master.
changeset:a57ff08d12d579ef1144201fc19014ecf02b6bbb

comment:14 Changed 7 years ago by iNode

  • Votes for changeset changed from andrew_b to andrew_b iNode
  • severity changed from on review to approved

comment:15 Changed 7 years ago by andrew_b

  • Status changed from reopened to closed
  • Votes for changeset changed from andrew_b iNode to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:16 Changed 7 years ago by gotar

  • Cc gotar@… added
  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Milestone changed from 4.7.0-pre2 to 4.7.0-pre4

It still doesn't work after mc restart. If info/tree panel is displayed when mc exits, panels.ini saves other_dir=. instead of real directory as remembered 'below'.

Changed 7 years ago by IMDagger

Fixed problem with saving path into panels.ini

comment:17 Changed 7 years ago by IMDagger

saved_path.patch add functionality to save Info, Tree and etc. panels state, and restore after.

comment:18 Changed 7 years ago by andrew_b

  • Votes for changeset commited-master deleted
  • Version changed from master to 4.7.0-pre3
  • severity changed from merged to on review

Created 38_tree_info_save_dir branch. Parent branch: master.
changeset:c699d0d2b19ba55ed3347a28b2706985393f5e4a

comment:19 Changed 7 years ago by angel_il

  • Votes for changeset set to angel_il

comment:20 Changed 7 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:21 Changed 7 years ago by andrew_b

  • Status changed from reopened to closed
  • Votes for changeset changed from angel_il slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:22 Changed 2 years ago by ossi

  • Description modified (diff)
  • Branch state set to no branch
  • Reporter changed from slavazanko to ptsekov

comment:23 Changed 2 years ago by andrew_b

  • Branch state changed from no branch to merged
Note: See TracTickets for help on using tickets.