Ticket #337 (closed defect: fixed)

Opened 8 years ago

Last modified 7 years ago

wrong $PS1 parser in command line input

Reported by: styx Owned by: slyfox
Priority: trivial Milestone:
Component: mc-core Version: 4.6.2
Keywords: commited-mc-4.6 commited-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by slyfox) (diff)

https://bugs.launchpad.net/ubuntu/+source/mc/+bug/330633

patch provided by Sergey Nizovtsev.

based on: mc-4.6
branch: 337_ps1_fix
changeset: 9041e6c81f4b2ae15e7bc3f733016ec9250ea5aa

Attachments

fix_osc_string_in_prompt.diff (600 bytes) - added by styx 8 years ago.
patch
fix_osc_string_in_prompt.2.diff (602 bytes) - added by snizovtsev 8 years ago.
New version

Change History

comment:1 Changed 8 years ago by styx

  • Status changed from new to accepted

Changed 8 years ago by styx

patch

comment:2 Changed 8 years ago by styx

  • Keywords vote-styx added
  • Description modified (diff)

comment:3 Changed 8 years ago by slavazanko

  • Keywords vote-slavazanko approved added

Looks good. My vote here.

comment:4 Changed 8 years ago by slavazanko

  • Keywords rework added; vote-styx vote-slavazanko approved removed

comment:5 Changed 8 years ago by slyfox

Patch looks wrong: it does not seem to handle correctly such pathological case:

PS1=esc(OSC)...esc(ST) ${GOOD_DATA1} esc(OSC)...esc(BEL) ${GOOD_DATA2}

As I understand it will drop all leaving ${GOOD_DATA2}

comment:6 Changed 8 years ago by styx

  • Description modified (diff)

now based on mc-4.6

Changed 8 years ago by snizovtsev

New version

comment:7 Changed 8 years ago by slyfox

  • Keywords review added; rework removed
  • Milestone changed from 4.7 to 4.6.2.1

Applied in slightly reworked form. Please review.

comment:8 Changed 8 years ago by slavazanko

  • Keywords vote-slavazanko added

looks good. Prompt show normal.
Vote here.

comment:9 Changed 8 years ago by styx

  • Keywords vote-styx approved added; review removed
  • Status changed from accepted to assigned
  • Owner changed from styx to slyfox

comment:10 Changed 8 years ago by styx

  • Status changed from assigned to testing
  • Keywords commited-mc-4.6 commited-master added; vote-slavazanko vote-styx approved removed
  • Resolution set to fixed

comment:11 Changed 8 years ago by styx

  • Status changed from testing to closed

comment:12 Changed 8 years ago by slyfox

  • Description modified (diff)

comment:13 Changed 7 years ago by anonymous

  • Milestone 4.6.2.1 deleted

Milestone 4.6.2.1 deleted

Note: See TracTickets for help on using tickets.