Ticket #2861 (closed defect: fixed)

Opened 12 years ago

Last modified 12 years ago

[PATCH] Additional error handling in edit_save_block()

Reported by: zaytsev Owned by:
Priority: minor Milestone: 4.8.5
Component: mcedit Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

Hi folks,

Here is a trivial patch to fix the following clang defect report:

Logic error Branch condition evaluates to a garbage value src /editor /editcmd.c 2960 4

​https://qa.nest-initiative.org/view/Midnight%20Commander/job/mc-clang-analyzer/Clang_Analyzer_Report_for_mc/report-G4KLXj.html#EndPath

Does this qualify for a direct commit or maybe you have a cleanup branch already?

Attachments

0001-Additional-error-handling-in-edit_save_block.patch​ (1.8 KB) - added by zaytsev 12 years ago.

Change History

Changed 12 years ago by zaytsev

comment:1 Changed 12 years ago by zaytsev

ping

comment:2 Changed 12 years ago by andrew_b

We haven't cleanup branch at this time. In any case, this ticket will not be forgotten before the next release.

comment:3 Changed 12 years ago by andrew_b

  • Blocked By 2876 added

comment:4 Changed 12 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to fixed
  • Blocked By 2876 removed

Fixed in master: [fbc013421c8a9ef1b0a413c611091bb78a15658d],
in 4.8.1-stable: [aa29f1b718fb30f9bce5005ff60ff6b93b70e91e].

Note: See TracTickets for help on using tickets.