Ticket #2811 (new defect)

Opened 4 years ago

"don't save passwords in history" option spoils some addresses

Reported by: gvy Owned by:
Priority: minor Milestone: Future Releases
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

This bugreport/patch is by arisu from opennet; my translation:

"Don't save passwords in history" option spoils addresses like "me@еxample.com:8666"

The patch is characterized as being the most mocking, terse and correct by its author.

--- original bits ---

  1. опция "не сохранять пароли в истории" портит адреса типа

"me@…:8666"

diff --git a/lib/widget/quick.c b/lib/widget/quick.c
index c6b415a..d33d1f4 100644
--- a/lib/widget/quick.c
+++ b/lib/widget/quick.c
@@ -110,7 +110,7 @@ quick_dialog_skip (QuickDialog * qd, int nskip)
             if ((qw->u.input.flags & 2) != 0)
                 in->completion_flags |= INPUT_COMPLETE_CD;
             if ((qw->u.input.flags & 4) != 0)
-                in->strip_password = TRUE;
+                in->strip_password = FALSE; /* TRUE; -- [censored] */
             qw->widget = (Widget *) in;
             *qw->u.input.result = NULL;
             break;
Note: See TracTickets for help on using tickets.