Ticket #276 (closed defect: fixed)

Opened 7 years ago

Last modified 6 years ago

Show total size of marked files.

Reported by: andrew_b Owned by: andrew_b
Priority: minor Milestone: 4.7.0-pre3
Component: mc-core Version: 4.7.0-pre1
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

Reimplemented displaying of marked files total size. Patch is attached. Detailed change log is provided in the patch.

Attachments

mc-show_total_size.patch (9.0 KB) - added by andrew_b 7 years ago.

Change History

Changed 7 years ago by andrew_b

comment:1 Changed 7 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Type changed from defect to enhancement

comment:2 Changed 7 years ago by andrew_b

The 276_show_total_size branch is created.

comment:3 Changed 7 years ago by angel_il

  • Keywords review vote-angel_il added

comment:4 Changed 7 years ago by slavazanko

  • Keywords vote-slavazanko approved added; review removed

looks good. Now, if "show ministatus" option switched off, total size of selected files shows anyway.

But in branch present some changes in Changelog:

 2009-02-05 Mikhail Pobolovets  <styx.mp@gmail.com>

-       * nl.po: update by mpol (#271)
+       * po/nl.po: update by mpol (#271)

 2009-02-05 Patrick Winnertz <winnie@debian.org>

@@ -17,13 +37,13 @@
        * lib/mc.lib: added patch on #219 by angel_il
        * edit/editcmd.c, configure.ac: removed obsolete own implementation of memove (#242)
        * vfs/extfs/u7z: patch from mandriva (#194)
-       * added andrew_b's patch for showing free space (#188)
+       * added Andrew Borodin's patch for showing free space (#188)

 2009-02-01 Enrico Weigelt, metux ITS <weigelt@metux.de>

        * src/util.c: fixed name_trunc() on NULL or empty parameters
        * src/achown.c: fixed unitialized var in init_chown_advanced()
-         (patch from andrew_b)
+         (patch from Andrew Borodin)
        * replaced gboolean by bool (from mhl/types.h)

This not good, but not critical.

In future don't do this, please. In branches must present realization only one idea.

My vote here. But in future remember about non-relative changes in branches, please.

comment:5 Changed 7 years ago by andrew_b

  • Keywords commited-master added
  • Status changed from accepted to testing
  • Resolution set to fixed

comment:6 Changed 7 years ago by styx

  • Status changed from testing to closed
  • Keywords vote-angel_il vote-slavazanko approved removed

comment:7 Changed 7 years ago by andrew_b

  • Status changed from closed to reopened
  • severity set to no branch
  • Resolution fixed deleted
  • Version changed from 4.6.2 to 4.7.0-pre1
  • Milestone changed from 4.7 to 4.7.0-pre3
  • Keywords commited-master removed
  • Type changed from enhancement to defect

In unicode locales, the size of marked files is displayed inaccurately: not centered horizontally and some rubbish is present in the end of displayed text.

Created 276_show_total_size_accurately branch. Parent branch: master.
changeset:54880d8c2b455dc761784f97ed440276cc1aeab6

comment:8 Changed 7 years ago by andrew_b

  • Status changed from reopened to accepted

comment:9 Changed 7 years ago by andrew_b

  • severity changed from no branch to on review

comment:10 Changed 7 years ago by iNode

  • Votes for changeset set to iNode

comment:11 Changed 7 years ago by slavazanko

  • Votes for changeset changed from iNode to iNode slavazanko
  • severity changed from on review to approved

looks good.

comment:12 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from iNode slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:13 Changed 7 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.