Ticket #260 (closed defect: fixed)

Opened 8 years ago

Last modified 7 years ago

fix missing include files

Reported by: metux Owned by: andrew_b
Priority: major Milestone: 4.7.0-pre1
Component: mc-core Version: 4.6.2
Keywords: commited-master Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by metux) (diff)

Several .c files are missing some includes (which makes trouble under certain circumstances)

branch:260_fix_includes
changeset:4704d7300b63ca652fa82dd65c4896150605f1ff

Change History

comment:1 Changed 8 years ago by metux

  • Status changed from new to accepted

comment:2 Changed 8 years ago by metux

  • Keywords review added

comment:3 Changed 8 years ago by metux

  • Description modified (diff)

comment:4 Changed 8 years ago by andrew_b

  • Owner changed from metux to andrew_b
  • Keywords rework added; review removed
  • Status changed from accepted to assigned

mhl is need to be removed.

comment:5 Changed 7 years ago by andrew_b

  • Keywords review added; rework removed

Rebased to current master.
Added other missed includes.
Added Changelog enties.

comment:6 Changed 7 years ago by andrew_b

  • Milestone changed from 4.6.3 to 4.7

Rebased to current master

comment:7 Changed 7 years ago by styx

  • Keywords vote-styx added

comment:8 Changed 7 years ago by styx

  • Keywords vote-styx removed

comment:9 Changed 7 years ago by slavazanko

branch 260_fix_includes now rebased to master

Review & vote.

comment:10 Changed 7 years ago by slavazanko

  • Milestone changed from 4.7 to 4.7.0-pre1

comment:11 Changed 7 years ago by andrew_b

Rebased to current master.

comment:12 Changed 7 years ago by slavazanko

  • Keywords vote-slavazanko added

looks good

comment:13 follow-up: ↓ 14 Changed 7 years ago by iNode

  • Keywords vote-iNode added

Yeah, looks good. Please provide link to changeset to speed up review.

Should we now check sources to consistency with main/headers.txt rules
or it is deprecated and should be updated / removed?

comment:14 in reply to: ↑ 13 Changed 7 years ago by andrew_b

Replying to iNode:

Yeah, looks good. Please provide link to changeset to speed up review.

Currently, you can view the diff:

git diff -- b09a107190ad5725a401fa1f699fe71b2da39b1b^ 9ef324f7bbe1d00d4365a32984747d5ecebc365c

Should we now check sources to consistency with main/headers.txt rules

I think, yes.

or it is deprecated and should be updated / removed?

No.

comment:15 Changed 7 years ago by andrew_b

  • Keywords commited-master added; review vote-slavazanko vote-iNode removed
  • Status changed from assigned to testing
  • Resolution set to fixed

Merged to master.

Start changeset:c7d04dd47a01bf2a42a56e2974c58c2c3d0812b6
End changeset:162bab7b70ba86f2dafe4177e80d251a4fbcba41

git log --pretty=oneline c7d04dd^..162bab7

comment:16 Changed 7 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.