Ticket #2598 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

vfs/extfs/helpers/u7z: improve handling of missing p7zip installation

Reported by: blueyed Owned by: andrew_b
Priority: major Milestone: 4.8.0
Component: mc-vfs Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

When p7zip is not installed, opening a 7z file will result in the following strange error message:

/usr/lib/mc/extfs.d/u7z: 78: l: not found

I will attach a patch to improve this by providing a descriptive error message to the user instead.

Attachments

0001-u7z-Improve-handling-of-missing-p7zip-binaries.patch (1.0 KB) - added by blueyed 5 years ago.

Change History

comment:1 Changed 5 years ago by andrew_b

  • Status changed from new to accepted
  • Keywords stable-candidate added
  • Votes for changeset set to andrew_b
  • Owner set to andrew_b
  • Milestone changed from Future Releases to 4.8.0

Thanks!
Applied with trivial modification.

Branch: 2598_u7z (parent: master).
changeset:4271c184de4f91bcf6d9e564f61fffcaf17d4a6a

comment:2 Changed 5 years ago by slavazanko

  • Branch state changed from no branch to on review

comment:3 Changed 5 years ago by slavazanko

  • Votes for changeset changed from andrew_b to andrew_b slavazanko
  • Branch state changed from on review to approved

comment:4 Changed 5 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b slavazanko to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

comment:5 Changed 5 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Votes for changeset changed from committed-master to committed-master committed-stable

comment:6 follow-up: ↓ 7 Changed 5 years ago by toto

Is this still working. I'm having problems getting it to work. Can i fidn documentation besides this on the issue ?
Anders.


Changed 9 months ago by blueyed

attachment 0001-u7z-Improve-handling-of-missing-p7zip-binaries.patch added
comment:1 Changed 7 months ago by andrew_b

Keywords stable - candidate added
Owner set to andrew_b
Votes for changeset set to andrew_b
Status changed from new to accepted
Milestone changed from Future Releases to 4.8.0
Thanks!
Applied with trivial modification.
Branch: 2598_u7z (parent: master).
event changeset:4271c184de4f91bcf6d9e564f61fffcaf17d4a6a
comment:2 Changed 7 months ago by slavazanko

Last edited 4 years ago by slavazanko (previous) (diff)

comment:7 in reply to: ↑ 6 Changed 5 years ago by blueyed

Replying to toto:

Is this still working. I'm having problems getting it to work. Can i fidn documentation besides this on the issue ?
Anders.

It should still be fixed.
From the 4.8.1-stable branch: https://github.com/MidnightCommander/mc/blob/4619723e8407b01f39fc106ff48b98a05cefef6e/src/vfs/extfs/helpers/u7z

What is your problem exactly?
You should make sure that you are using a version of mc which contains the fix (4.7.5 or later).

Note: See TracTickets for help on using tickets.