Ticket #2586 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

Extended keybingings are broken

Reported by: andrew_b Owned by: andrew_b
Priority: major Milestone: 4.8.0-pre2
Component: mcedit Version: 4.8.0-pre1
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description (last modified by andrew_b) (diff)

There are two bugs with extended keybingings in mcedit.

  1. ctrl-x in default keymap is used twice:
    1. as shotrcut for WordRight action (see #2404)
    2. as shortcut for extended keybindings mode. Because of #2404, we should change shortcut for editor.ExtendedKeyMap action.
  2. Extended shortcuts like ctrl-x ctrl-x or ctrl-x alt-x are available but extended shortcuts like ctrl-x x are not.

Change History

comment:1 Changed 5 years ago by andrew_b

  • Description modified (diff)

comment:2 Changed 5 years ago by andrew_b

  • Status changed from new to accepted
  • Keywords stable-candidate added
  • Owner set to andrew_b
  • Branch state changed from no branch to on review

Branch: 2586_mcedit_extended_keybindings (parent: master).
Initial changeset:b0583850c6f58de22ea89e045c7ea24df11fc4e2

comment:3 Changed 5 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:4 Changed 5 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:5 Changed 5 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master.
changeset:eb13abc437323a054a16bbc0c445cfe6b4e61f8d

git log --pretty=oneline c4af1f2..eb13abc

comment:6 Changed 5 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Votes for changeset changed from committed-master to committed-master committed-stable

Cherry-picked to 4.7.5-stable.
Initial changeset:5f0cef1e6e8982cd0503d025d7c08a36f2fece74

Note: See TracTickets for help on using tickets.