Ticket #2580 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

File size column is bogus for widths above 9

Reported by: ply Owned by: andrew_b
Priority: major Milestone: 4.8.0-pre2
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

The panel column for the file sizes displays a value formatted according to the column width. However, width values above 9 produce undefined behavior. For example the width of 10 displays all file sizes in kilobytes, the width of 11 in megabytes, and the width of 12 again in bytes.

This is probably due to the function size_trunc_len in lib/util.c using a fixed array of constants that have values only up to 9 decimal places, and not checking for this limit. Please add a check, and a couple of more allowed widths, to let me use 10 digits for my file sizes. :-)

Change History

comment:1 Changed 5 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted
  • Branch state changed from no branch to on review
  • Milestone changed from Future Releases to 4.8.0-pre2

Branch: 2580_file_size_column (parent: master).
Initial changeset:111213688eb3f4d2bd5439d799e9bc5c116e6ace

comment:2 Changed 5 years ago by andrew_b

  • Keywords stable-candidate added
  • Version changed from 4.8.0-pre1 to master

comment:3 Changed 5 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:4 Changed 5 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:5 Changed 5 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master.
changeset:8353224997acea0ae273791ff929dd60eaa6ddda

git log --pretty=oneline 4aebb59..8353224

comment:6 Changed 5 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Votes for changeset changed from committed-master to committed-master committed-stable

Cherry-picked to 4.7.5-stable.
Initial changeset:6d5ea7426baceea307febbafa5d40099f97e0b3a

Note: See TracTickets for help on using tickets.