Ticket #257 (closed defect: fixed)

Opened 8 years ago

Last modified 7 years ago

Highlight width issues (UTF-8)

Reported by: egmont Owned by: winnie
Priority: minor Milestone: 4.7.0-pre1
Component: mc-core Version: 4.6.2
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description

The UTF-8 patch introduces several issues regarding the width of a highlighed (cyan-background) field, if it contains accented characters.

Long time ago I've created some patches to address them, and posted them to mc-devel. Probably they are already included in some major Linux distros as well. Please apply them to your UTF-8 patch, so that these fixes reach everyone who want UTF-8 in mc. Thanks!

I send multiple patches fixing multiple similar issues; I know it's generally not wise and I should probably file separate tickets, but they all rely on some common codebase, so I thought it'd be simpler this way.

The fixes are:

  • Correct width for the bottom row's buttons (if they have accents)
  • Correctly highlight the full line in hotlists (alt+H) (if the entry has accented letters)
  • Correctly highlight quick filename search (ctrl+S) (if the currently matching filename prefix has accented letters)
  • Fix filename/command completion (if the already typed prefix of the filename/command has accented letters - ok, this is not about highlighting, but it's the same story)

Attachments

00-70-utf8-common.patch (1.2 KB) - added by egmont 8 years ago.
Common base for the subsequent patches
00-73-utf8-bottom-buttons-width.patch (835 bytes) - added by egmont 8 years ago.
Fix cyan rectangles in the bottom row
00-76-utf8-hotlist-highlight.patch (716 bytes) - added by egmont 8 years ago.
Fix hotlist entries
00-77-utf8-filename-search-highlight.patch (1.0 KB) - added by egmont 8 years ago.
Fix quick filename search
00-84-utf8-complete.patch (2.3 KB) - added by egmont 8 years ago.
Fix completion

Change History

Changed 8 years ago by egmont

Common base for the subsequent patches

Changed 8 years ago by egmont

Fix cyan rectangles in the bottom row

Changed 8 years ago by egmont

Fix hotlist entries

Changed 8 years ago by egmont

Fix quick filename search

Changed 8 years ago by egmont

Fix completion

comment:1 Changed 7 years ago by winnie

  • Status changed from new to accepted
  • Owner set to winnie
  • Milestone changed from 4.6.2.1 to UTF8 Support

Thanks, I'll take a look on them but the clearly belong not into the 4.6.2.1 milestone..

comment:2 Changed 7 years ago by winnie

  • Status changed from accepted to testing
  • Resolution set to fixed

Patches are added into the two HACK_utf8 branches.. they will be automatically included in the next release.

comment:3 Changed 7 years ago by winnie

  • Status changed from testing to closed

comment:4 Changed 7 years ago by angel_il

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Milestone UTF8 Support deleted

need check it

comment:5 Changed 7 years ago by styx

  • severity set to no branch
  • Milestone set to future releases

comment:6 Changed 7 years ago by angel_il

  • Status changed from reopened to closed
  • Resolution set to fixed

comment:7 Changed 7 years ago by slavazanko

  • Milestone changed from future releases to 4.7.0-pre1
Note: See TracTickets for help on using tickets.