Ticket #2545 (closed defect: fixed)

Opened 5 years ago

Last modified 5 years ago

[PATCH] Save input line content in history only if has changed

Reported by: cosoleto Owned by: andrew_b
Priority: major Milestone: 4.8.0-pre1
Component: mc-core Version: master
Keywords: Cc: gotar@…
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description

It's possible users reuse the same content of a dialog or just
enable/disable some options available, then saving the history is
pointless.

Attachments

0001-Save-input-line-content-in-history-only-if-has-chang.patch (2.4 KB) - added by cosoleto 5 years ago.
Patch

Change History

comment:1 Changed 47 years ago by andrew_b

  • Blocked By 2541 removed

(In #2541) Merged to master.
changeset:fcfa76be3d315f23dd5c2b282234f9d9fc39b69a

git log --pretty=oneline 417d550..fcfa76b

Changed 5 years ago by cosoleto

Patch

comment:1 Changed 5 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted

comment:2 Changed 5 years ago by slavazanko

  • Status changed from accepted to assigned
  • Owner changed from slavazanko to andrew_b
  • Blocked By 2541 added

comment:3 Changed 5 years ago by andrew_b

The proposed patch is not quite correct. Comparison of input content and top of history is not enough to decide whether the history was changed or not. E.g. history list supports the delete capability of its items (see #1445). If user made some clean up of history but didn't change the input content, the history should be saved.

comment:4 Changed 5 years ago by andrew_b

  • Keywords stable-candidate added
  • severity changed from no branch to on review
  • Milestone changed from 4.8 to 4.8.0-pre1

Created 2545_save_history branch (parent: master).
Initial changeset:a9e8ed4d28480fa2e2cea52b96d64a6209374cf0

comment:5 Changed 5 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:6 Changed 5 years ago by iNode

  • Votes for changeset changed from slavazanko to slavazanko iNode
  • severity changed from on review to approved

comment:7 Changed 5 years ago by andrew_b

  • Votes for changeset changed from slavazanko iNode to committed-master
  • severity changed from approved to merged

Merged to master.
changeset:7d5266992042a16aef89d7d4ea77816c0e8f7a45

git log --pretty=oneline f3ae923..7d52669

comment:8 Changed 5 years ago by andrew_b

  • Status changed from assigned to testing
  • Resolution set to fixed

comment:9 follow-up: ↓ 10 Changed 5 years ago by andrew_b

  • Status changed from testing to reopened
  • Votes for changeset committed-master deleted
  • Version changed from 4.7.5 to master
  • Resolution fixed deleted
  • severity changed from merged to on review

The bug was introduced in changeset:5ffcffbeb6bdda29698bc823e389f5126b13ef08. The new input content is saved in history.

Created 2545_save_history_fix branch (parent: master).
changeset:ce49f91ab6b33a03bc253e8bce43c4f69aec5c08

Please review.

comment:10 in reply to: ↑ 9 Changed 5 years ago by andrew_b

Replying to andrew_b:

is saved

is not saved, of course.

comment:11 Changed 5 years ago by slavazanko

  • severity changed from on review to no branch
  • Branch state set to on review

comment:12 Changed 5 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:13 Changed 5 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:14 Changed 5 years ago by andrew_b

  • Status changed from reopened to closed
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master.
changeset:7963f44daad81415ac6d1a547a5363d8f3ba7fe4

git log --pretty=oneline ba09144..7963f44

comment:15 Changed 5 years ago by slavazanko

  • Keywords stable-candidate removed

won't fix in stable

comment:16 Changed 5 years ago by gotar

  • Cc gotar@… added
Note: See TracTickets for help on using tickets.