Ticket #2526 (accepted enhancement)

Opened 5 years ago

Last modified 15 months ago

mcedit: use Office/Word-style tab markers

Reported by: jengelh Owned by: angel_il
Priority: trivial Milestone: Future Releases
Component: mcedit Version: 4.7.5
Keywords: Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description

Suggestion:

Also among the tickets copied from Savannah was a suggestion to reduce the <------> clutter highlight_tabs makes. To that end I had written a patch to simply place tab markers similar to those shown in contemporary document editors in office suites - single arrow in the middle of the space taken up by the tab.

===
The following changes since commit 78019b896ba0e59ba886ecf500747cbe77dbc7cb:

Merge branch '2520_ctrlg_closes_panels' (2011-03-30 16:18:45 +0400)

are available in the git repository at:

git://dev.medozas.de/mc 2526_wordstyle_tab

Jan Engelhardt (1):

mcedit: use Office/Word?-style tab markers

src/editor/editdraw.c | 33 +++++----------------------------
1 files changed, 5 insertions(+), 28 deletions(-)

Attachments

before.png (49.4 KB) - added by jengelh 5 years ago.
example screenshot of deep-nested code
after.png (43.9 KB) - added by jengelh 5 years ago.
example screenshot of deep-nested code, using wtabs
2526.diff (2.6 KB) - added by jengelh 5 years ago.

Change History

Changed 5 years ago by jengelh

example screenshot of deep-nested code

Changed 5 years ago by jengelh

example screenshot of deep-nested code, using wtabs

Changed 5 years ago by jengelh

comment:1 Changed 5 years ago by andrew_b

Did you try your patch on 7-bit and 8-bit locales?

comment:2 Changed 5 years ago by andrew_b

  • Priority changed from major to trivial

comment:3 Changed 5 years ago by ossi

i don't like that, because if there are spaces around the tabs and you don't have general whitespace visualisation enabled, you essentially have to guess where the tabs actually are, which is counterproductive for the goal of this feature (producing clean tabbing).

comment:4 Changed 5 years ago by angel_il

now 'tab' drawn as 3 parts:
start - char '<'
middle - char '-'
end - char '>'

currently '<', '-', '>' is hardcoded chars
if these characters are defined in your skin we do not need change 'edit_draw_this_line'...

for example:
current behaviour

[widget-editor]
    start-sign-tab=<
    middle-sign-tab=-
    end-sign-tab=>

like this ticket

[widget-editor]
    start-sign-tab=' '
    middle-sign-tab=' '
    end-sign-tab=→

invisible tabs

[widget-editor]
    start-sign-tab=' '
    middle-sign-tab=' '
    end-sign-tab=' '

???
PROFIT

comment:5 Changed 5 years ago by birdie

Then, please,

tab-first-char
tab-middle-char
tab-last-char

not "sign" "start" "end", but "character" "first" "last"

comment:6 Changed 5 years ago by angel_il

  • Owner set to angel_il
  • Status changed from new to accepted
  • Branch state set to no branch

comment:7 Changed 15 months ago by andrew_b

  • Milestone changed from 4.8 to Future Releases
Note: See TracTickets for help on using tickets.