Ticket #2503 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

copy/move dialog: wrong total bytes counter for subdirs

Reported by: gotar Owned by: andrew_b
Priority: minor Milestone: 4.8.2
Component: mc-core Version: 4.7.5
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master committed-stable

Description

When file_op_compute_totals=0 it gets really hard to find out operation progress status for directories (only). There's no cumulative progress bar (because dialog doesn't know total size), file counter shows weird values like "Files processed: 36 of 0", ETA keeps '0:00.01' with no average transfer speed in braces and middle line shows always "Total: 0 of 0". At least these fixes should be made:

  1. Total counter should be running additionally for data copied within subdirectories,
  2. ETA should be vanished (as it's impossible to compute it anyway without prescan),
  3. file counter should append '(+ subdirs)' string if any dir is selected for operation (or marked).

One trivial glitch is that marked directory counts as "Files processed: .. of 1" while selected directory doesn't count ("Files processed: .. of 0").

Change History

comment:1 Changed 5 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Type changed from enhancement to defect
  • Branch state set to on review
  • Milestone changed from 4.8 to 4.8.2

Branch: 2503_compute_totals (parent: master).
Initial changeset:a3ad5a2af718f6b0f3f650a901d3139d4c015e1e

comment:2 Changed 5 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:3 Changed 5 years ago by andrew_b

  • Keywords stable-candidate added

comment:4 Changed 5 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:5 Changed 5 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master.
changeset:6318295a2bd80373c2270effe9063140d606e5e4

git log --pretty=oneline be6590a..6318295

comment:6 Changed 4 years ago by andrew_b

  • Keywords stable-candidate removed
  • Status changed from testing to closed
  • Votes for changeset changed from committed-master to committed-master committed-stable

Cherry-picked to 4.8.1-stable.
Initial changeset:e9d0b7898c462916b577e101e726db0a8f75e700

git log --pretty=oneline d658d1d..0a952de
Note: See TracTickets for help on using tickets.