Ticket #2250 (closed enhancement: fixed)

Opened 6 years ago

Last modified 4 years ago

case insensitivity for mc.ext

Reported by: nerijus Owned by: andrew_b
Priority: major Milestone: 4.8.5
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: merged Votes for changeset: committed-master

Description (last modified by andrew_b) (diff)

Please apply, there are quite a lot .ISO files:
--- mc.ext.orig 2010-06-16 11:55:31.000000000 +0300
+++ mc.ext 2010-06-29 03:14:58.163560374 +0300
@@ -239,7 +239,7 @@

View=%view{ascii} apt-cache show echo %p | sed 's/\([0-9a-z.-]*\).*/\1/'

# ISO9660

-regex/\.iso$
+regex/\.([iI][sS][oO])$

Open=%cd %p#iso9660
View=%view{ascii} isoinfo -l -i %f

Change History

comment:1 follow-up: ↓ 6 Changed 6 years ago by zaytsev

  • Status changed from new to accepted
  • Owner set to zaytsev
  • Version changed from 4.7.2 to master
  • Milestone changed from 4.7 to 4.7.3

As per WorkingGuidelines? for mc.ext a branch is needed. May I just put this into cleanup, guys, sounds trivial enough to not mess anything up?

comment:2 follow-up: ↓ 3 Changed 6 years ago by ossi

i think it would be a good idea if the matching expressions had the possibility to be case-insensitive (and it would probably make sense if that option was on by default, except that doing so now would make existing .ext files incompatible). possible syntaxes are:

shell/.iso/i

or

shell:i/.iso

the first variant looks more familiar and nicer, while the second one can be guaranteed to be backwards-compatible without quoting slashes in the pattern somehow (though that would be relevant only for the directory keyword, which is practically unused, so it may be acceptable to add new quoting rules to it).

comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed 6 years ago by andrew_b

I think we need a special ticket for modification of .ext file processing.

comment:4 in reply to: ↑ 3 Changed 6 years ago by andrew_b

Replying to andrew_b:

I think we need a special ticket for modification of .ext file processing.

#2118 could be a candidate for that.

comment:5 Changed 6 years ago by ossi

nah, that ticket is "too big", this minor enhancement will drown there. however, it is probably true that #2118 would supersede my suggestion when finally implemented.

anyway, i think you are seriously overdoing it with the processes. ;)
just apply the patch "silently" to the cleanup branch (if you *want* to have it in right now) and repurpose the ticket for my more general approach to the problem.

comment:6 in reply to: ↑ 1 Changed 6 years ago by andrew_b

Replying to zaytsev:

May I just put this into cleanup, guys, sounds trivial enough to not mess anything up?

I don't mind.

comment:7 Changed 6 years ago by zaytsev

Committed in 2243_code_cleanup branch.

comment:8 Changed 6 years ago by zaytsev

The ticket can now be re-purposed if needed.

comment:9 Changed 6 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Description modified (diff)

comment:10 Changed 6 years ago by andrew_b

  • Keywords committed-master added
  • severity changed from no branch to merged

comment:11 Changed 6 years ago by andrew_b

  • Keywords committed-stable added

comment:12 Changed 6 years ago by angel_il

  • Status changed from testing to closed

comment:13 Changed 6 years ago by ossi

hmm, it thought we wanted to re-purpose this ticked according to my two previous comments?

comment:14 Changed 5 years ago by andrew_b

  • Status changed from closed to reopened
  • severity changed from merged to no branch
  • Summary changed from iso case insensitivity for mc.ext to case insensitivity for mc.ext
  • Priority changed from trivial to major
  • Milestone changed from 4.7.3 to 4.8
  • Resolution fixed deleted

Reopened.

shell/ and regex/ expressions should have case-insensitive flag. Summary was changed.

comment:15 Changed 5 years ago by andrew_b

  • Keywords committed-master committed-stable removed

comment:16 Changed 4 years ago by andrew_b

  • Owner changed from zaytsev to andrew_b
  • Status changed from reopened to accepted
  • Branch state set to on review
  • Milestone changed from 4.8 to 4.8.5

Branch: 2250_mcext_case_insense (parent: master).
Initial changeset:e0afbb1e2722cb14ae09a7a3ab6aae3b5a8d84dd

For case insensitive regexes and shell patterns following syntax is implemented: regex/i and shell/i.

comment:17 Changed 4 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:18 Changed 4 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • Branch state changed from on review to approved

comment:19 Changed 4 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to committed-master
  • Resolution set to fixed
  • Branch state changed from approved to merged

Merged to master: [bcfb8c8f984b818644ee485daa83542473d85bc1].

git log --pretty=oneline 06e874e..bcfb8c8

comment:20 Changed 4 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.