Ticket #2119 (closed defect: fixed)

Opened 14 years ago

Last modified 14 years ago

some-trivial-corrections

Reported by: vit_r Owned by: andrew_b
Priority: trivial Milestone: 4.7.2
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

a few different trivial corrections

Attachments

2119-some-trivial-corrections.patch​ (4.7 KB) - added by vit_r 14 years ago.
some-trivial-corrections

Change History

Changed 14 years ago by vit_r

some-trivial-corrections

comment:1 Changed 14 years ago by vit_r

2119-some-trivial-corrections.patch
+++ b/src/cons.handler.c

-	close (pipefd1[1]);
-	close (pipefd2[0]);
+        if (pipefd1[1] > 2) {
+            close (pipefd1[1]);
+            close (pipefd2[0]);
+        }

prevents:

==--== Warning: invalid file descriptor -1 in syscall close()
==--==    by 0x80704AF: handle_console (cons.handler.c:396)
==--==    by 0x809A5DD: main (main.c:2134)

comment:2 Changed 14 years ago by andrew_b

  • Blocked By 2097 added

Most parts are applied in #2097.

comment:3 Changed 14 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted

comment:4 Changed 14 years ago by andrew_b

  • Blocked By 2097 removed

(In #2097) Merged to master.
changeset:f4e369c222543f864adfde7be211e9881cdf30a2

git log --pretty=oneline 4cea5be^...f4e369c

comment:5 Changed 14 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:6 Changed 14 years ago by andrew_b

  • Status changed from testing to closed

comment:7 Changed 14 years ago by andrew_b

  • Votes for changeset set to committed-master
  • severity changed from no branch to merged
Note: See TracTickets for help on using tickets.