Ticket #2097 (closed task: fixed)

Opened 6 years ago

Last modified 6 years ago

Cleanup for current master

Reported by: vit_r Owned by: andrew_b
Priority: trivial Milestone: 4.7.2
Component: mc-core Version: 4.7.1
Keywords: code cleanup Cc: zaytsev
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by angel_il) (diff)

Clean-up-of-4.7.1-assignments-02.diff is not git patch

Attachments

Clean-up-of-4.7.1-assignments-02.diff (48.1 KB) - added by vit_r 6 years ago.
getting-out-assignments-from-some-ifs
2097-src-help.c-interactive_display-rm-UNused-argument.patch (4.4 KB) - added by vit_r 6 years ago.
src/help.c interactive_display () removing UN used argument
2097-some-unused-lines-in-mc-4.7.1.diff (27.9 KB) - added by vit_r 6 years ago.
some-unused-lines-in-mc-4.7.1
un-used-4.7.1-macros.lst (7.8 KB) - added by vit_r 6 years ago.
un-used-mc-4.7.1-enumerators.lst (1.6 KB) - added by vit_r 6 years ago.
2097-some-unused-in-mc-4.7.1-lines-2.diff (6.7 KB) - added by vit_r 6 years ago.
some-unused-in-mc-4.7.1-lines-2
2097-getting-rid-of-else_return-in-mc-4.7.1.diff (6.9 KB) - added by vit_r 6 years ago.
2097-src-find.c-subshell.c-mem-leaks.diff (2.0 KB) - added by vit_r 6 years ago.
src-find.c-subshell.c-mem-leaks
0001-ChangeLog-in-its-current-form-does-not-strictly-make.patch (828 bytes) - added by zaytsev 6 years ago.
Rewording of the changelog.

Change History

Changed 6 years ago by vit_r

getting-out-assignments-from-some-ifs

comment:1 Changed 6 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to wontfix
  • Description modified (diff)

No need special ticket for this. This clean up will make with lowest priority simultaneously with other work.

comment:2 Changed 6 years ago by slavazanko

  • Keywords code cleanup added
  • Status changed from closed to reopened
  • Type changed from enhancement to task
  • Resolution wontfix deleted
  • Summary changed from Clean-up-of-4.7.1-outing-assignments to Cleanup for current master

Ticket stil alive until next release out.

Ticket will contain just cleanup/indentation thinks

Changed 6 years ago by vit_r

src/help.c interactive_display () removing UN used argument

comment:3 Changed 6 years ago by andrew_b

attachment 2097-src-help.c-interactive_display-rm-UNused-argument.patch added

This patch must not be applied due to #1561.

Changed 6 years ago by vit_r

some-unused-lines-in-mc-4.7.1

Changed 6 years ago by vit_r

Changed 6 years ago by vit_r

Changed 6 years ago by vit_r

some-unused-in-mc-4.7.1-lines-2

comment:4 Changed 6 years ago by vit_r

2097-some-unused-in-mc-4.7.1-lines-2.diff
in src/panelize.c just renaming

-    external;
+    eksternal;

comment:5 Changed 6 years ago by vit_r

2097-getting-rid-of-else_return-in-mc-4.7.1.diff

  • lib/vfs/mc-vfs/fish.c
  • lib/vfs/mc-vfs/vfs.c

In mc_opendir() lines are left unaligned to clearly show that:

	"Only minor changes are made"

Even revealed bugs are left as next step :-)

Changed 6 years ago by vit_r

comment:6 Changed 6 years ago by andrew_b

Created 2097_cleanup_master branch. Parent branch is master.

comment:7 Changed 6 years ago by andrew_b

  • Blocking 2119 added

(In #2119) Most parts are applied in #2097.

comment:8 Changed 6 years ago by andrew_b

  • Blocking 2078 added

(In #2078) Applied with some modifications in #2097.

comment:9 Changed 6 years ago by andrew_b

  • Blocking 2041 added

(In #2041) Applied with some modifications in 2097.

comment:10 Changed 6 years ago by andrew_b

  • Blocking 1949 added

(In #1949) Applied in #2097.

Changed 6 years ago by vit_r

src-find.c-subshell.c-mem-leaks

comment:11 Changed 6 years ago by andrew_b

attachment 2097-src-find.c-subshell.c-mem-leaks.diff added

There are no memleaks there.

comment:12 Changed 6 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from reopened to accepted

comment:13 Changed 6 years ago by angel_il

  • Description modified (diff)

Changed 6 years ago by zaytsev

Rewording of the changelog.

comment:14 Changed 6 years ago by zaytsev

  • Cc zaytsev added

Please check out the attached patch against ChangeLog? and tell me if I may commit this to the cleanup & stable branch.

comment:15 Changed 6 years ago by andrew_b

I'm agree with this patch.

comment:16 Changed 6 years ago by zaytsev

Done, thanks.

comment:17 Changed 6 years ago by slavazanko

  • severity changed from no branch to on review

Branch: 2097_cleanup_master

My last commit is changeset:06b4a5e2d49d5055dc7ec747c9045ee1381bdbbd

review, please.

comment:18 Changed 6 years ago by andrew_b

  • Votes for changeset set to andrew_b

comment:19 Changed 6 years ago by angel_il

  • Votes for changeset changed from andrew_b to andrew_b angel_il
  • severity changed from on review to approved

comment:20 Changed 6 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from andrew_b angel_il to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged
  • Blocking 1949, 2041, 2078, 2119 removed

Merged to master.
changeset:f4e369c222543f864adfde7be211e9881cdf30a2

git log --pretty=oneline 4cea5be^...f4e369c

comment:21 Changed 6 years ago by andrew_b

  • Status changed from testing to closed

comment:22 Changed 6 years ago by andrew_b

  • Votes for changeset changed from commited-master to committed-master
Note: See TracTickets for help on using tickets.