Ticket #2069 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Memory leaks

Reported by: vit_r Owned by: andrew_b
Priority: major Milestone: 4.7.2
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description (last modified by andrew_b) (diff)

lib/mcconfig/common.c missing mc_config_deinit (tmp_config);
lib/vfs/mc-vfs/direntry.c missing vfs_s_close (fh);
src/editor/editcmd.c missing g_free (search_string);

in lib/skin/colors.c making it in MC-fashion only

Attachments

2069-missing-mc_config_deinit-vfs_s_close-g_free.patch (3.6 KB) - added by vit_r 7 years ago.

Change History

comment:1 Changed 7 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Description modified (diff)
  • Milestone changed from 4.7 to 4.7.2

Created branch 2069_memory_leaks. Parent branch is master.
Initial changeset:62b66be5b7f80e13ece43239194a90e10683a5d4

comment:2 Changed 7 years ago by andrew_b

  • severity changed from no branch to on review

comment:3 Changed 7 years ago by andrew_b

  • Votes for changeset set to andrew_b

Vote for the last commit in the branch.

comment:4 Changed 7 years ago by andrew_b

  • Blocking 2108 added

(In #2108) Patch for fish.c is correct. Thanks! Applied in #2069.
Patch for edit.c is totally wrong.

comment:5 Changed 7 years ago by andrew_b

  • Votes for changeset andrew_b deleted

Now my commit is last one in branch. My vote has been removed.

comment:6 Changed 7 years ago by andrew_b

  • Summary changed from missing-mc_config_deinit-vfs_s_close-g_free to Memory leaks

comment:7 Changed 7 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:8 Changed 7 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:9 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged
  • Blocking 2108 removed

Merged to master.
changeset:a5be50743235d39a4633c83b514879be142f4c26

git log --pretty=oneline afa93bb..a5be507

comment:10 Changed 7 years ago by andrew_b

  • Status changed from testing to closed
  • Votes for changeset changed from commited-master to commited-master commited-stable

Cherry-picket to 4.7.0-stable.

git log --pretty=oneline b8f55c8^..90d33f1
Note: See TracTickets for help on using tickets.