Ticket #1999 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Visible inactive menu colors broken

Reported by: egmont Owned by: andrew_b
Priority: minor Milestone: 4.7.1
Component: mc-skin Version: 4.7.0.2
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description

Up to (including) 4.7.0.1 the top and the bottom status bar had the same colors: black text over cyan background.

In 4.7.0.2 the top bar's text color is broken: the letters are white and yellow, just as in older versions after invoking the menu (F9).

I find the new colors way too intrusive, as well as highlighting the shortcut key doesn't make any sense since shortcuts are not available until you press F9. Furthermore, mcview and mcedit still uses black, it's only the two-panel screen of mc that's different. Hence I believe this is a regression, not a new feature.

Change History

comment:1 in reply to: ↑ description Changed 6 years ago by andrew_b

  • Status changed from new to closed
  • Resolution set to wontfix

Replying to egmont:

In 4.7.0.2 the top bar's text color is broken: the letters are white and yellow, just as in older versions after invoking the menu (F9).

Are you talking about menu bar in file panels?

I find the new colors way too intrusive, as well as highlighting the shortcut key doesn't make any sense since shortcuts are not available until you press F9. Furthermore, mcview and mcedit still uses black, it's only the two-panel screen of mc that's different. Hence I believe this is a regression, not a new feature.

Menu bar is not status bar. Details see in #1702 and in 'mc at gnome dot org' mailing list in
http://mail.gnome.org/archives/mc/2010-January/msg00083.html subthread.

comment:2 Changed 6 years ago by andrew_b

  • Version 4.7.0.2 deleted
  • Milestone 4.7 deleted

comment:3 Changed 6 years ago by egmont

Sorry if using incorrect terminology. I mean whatever is in the topmost row right after a brand new user starts up mc for the first time ("Left File Command Options Right").

comment:4 Changed 6 years ago by andrew_b

It is menu bar. It is visible because option

[x] menuBar visible

is on by default.

comment:5 follow-up: ↓ 6 Changed 6 years ago by egmont

Care to read my bugreport again and try to understand?

I was not talking about the menubar being visible or not. I was talking about the colors used in the menu bar. I was talking about something that changed from 4.7.0.1 to 4.7.0.2 and I'm pretty sure the change wasn't intentional.

Brand new user starts up mc 4.7.0.2 for the first time. The menu bar is visible of course, but its colors are not what you'd expect. It's white-yellow text on cyan, though it should be black on cyan until you press F9.

comment:6 in reply to: ↑ 5 Changed 6 years ago by andrew_b

Replying to egmont:

Care to read my bugreport again and try to understand?

I understood you right.

I was not talking about the menubar being visible or not. I was talking about the colors used in the menu bar.

Yes, I was talking about that too.

I was talking about something that changed from 4.7.0.1 to 4.7.0.2 and I'm pretty sure the change wasn't intentional.

Brand new user starts up mc 4.7.0.2 for the first time. The menu bar is visible of course, but its colors are not what you'd expect. It's white-yellow text on cyan, though it should be black on cyan until you press F9.

Why? What do you thing about #1702? Please write you arguments there.

comment:7 Changed 6 years ago by egmont

[If you really did understand me, I have no clue why you started talking about something completely irrelevant (the option whether menubar is visible or not). Nevermind, it really doesn't matter, let's forget about it.]

1702 talks about background color. I'm talking about foreground color.

1702 was filed 4 months ago. I am talking about a change in appearence that happened between 4.7.0.1 (released 5 weeks ago) and 4.7.0.2 (released 3 days ago). I have no clue how anyone could have reported a bug 4 months ago, if the bug was introduced during the last 5 weeks.

1702 talks about trying a custom skin. I'm not using any custom one, I use whatever is the default of mc and talking about that one.

Based on these, 1702 seems to be irrelevant. I admit I did not go ahead and look at the patch and understand the source code of mc, I don't know and don't want to know anything about mc's skin support, I just don't care. I'm only looking at the default colors from an average user's point of view.

I don't understand why I should post my arguments in an apparently irrelevant bug report. I have already posted my arguments here in my original post. Couldn't we discuss it here? Could you come up with counter arguments if you think my reasoning is invalid?

Once again: The default colors of the menubar have changed from 4.7.0.1 to 4.7.0.2, that's a fact. Having the shortcut keys highlighted (yellow opposed to white) when they are not accessible doesn't make sense at all, that's a fact too. The new colors are way too intrusive and make mc's main screen uglier, that's my personal opinion. Based on all of these, I believe this was an unintended change which should be reverted. And yet again I see no connection between 1702 and this one - if there's any, please explain to me what that is.

comment:8 Changed 6 years ago by angel_il

ok, can you show 2 screenshots
1 - as you need
2 - how to you have (at now)

comment:9 Changed 6 years ago by egmont

OMG...

andrew_b assured me he at least understood what my problem was. I have already explained twice. Let me explain for the third time.

Remove all your .mc config files, and start up mc-4.7.0.1. Notice the foreground color of the topmost row ("Left File Command...").

Remove all your .mc config files, and start up mc-4.7.0.2. Notice the foreground color of the topmost row ("Left File Command...").

These two are different. I believe that the one of mc-4.7.0.1 is the correct, and 4.7.0.2 is buggy. Why? I'm not going to explain it for the third time, please read my previous entries.

Please tell me which bit of this description you don't understand so that you ask for a screenshot - I believe taking a screenshot for me would take much more time than for you to read the bugreport again.

I would happily create screenshots if that would help demonstrate what the problem is or helped in communication. I'm pretty sure this is not the case here - I can't help that you're too lazy to read and try to understand my sentences.

comment:10 Changed 6 years ago by andrew_b

  • Status changed from closed to reopened
  • Milestone set to 4.7.1
  • Version set to 4.7.0.2
  • Resolution wontfix deleted
  • Summary changed from header colors broken to Visible incative menu colors broken

comment:11 Changed 6 years ago by andrew_b

  • Summary changed from Visible incative menu colors broken to Visible inactive menu colors broken

comment:12 follow-up: ↓ 13 Changed 6 years ago by angel_il

about me:

I can't help that you're too lazy to read and try to understand my sentences.

no, i have problem with English, and i try understand you...
about foreground colors in inactive menu... in 4.7.0.2 foreground color pair get from skin, in 4.7.0.1 from hardcoded colors (it's wrong way).
maybe need add new color pair into skins
now we have

[menu]
    _default_=white;cyan
    menuhot=yellow;cyan
    menusel=white;black
    menuhotsel=yellow;black

maybe need

inactivemenuhot=
inactivemenusel=
inactivemenuhotsel=

comment:13 in reply to: ↑ 12 Changed 6 years ago by andrew_b

Replying to angel_il:

maybe need

inactivemenuhot=
inactivemenusel=
inactivemenuhotsel=

No. Now I agree with egmont, inactive menu should not have visualized hotkeys and other elements because inactive menu is inactive (just a passive widget) and hotkeys can confuse user. I think that one 'inactivemenu' color pair is enough.

comment:14 Changed 6 years ago by andrew_b

  • Status changed from reopened to accepted
  • Owner set to andrew_b
  • Component changed from mc-core to mc-skin
  • severity changed from no branch to on review

Created 1999_inactive_menu_colors branch. Parent branch is master.
changeset:52f4ab1d6d9638b27a0849dfa6dc107b48b6eccb

Maybe some correction of 'menuinactive' value is need in some skins.

comment:15 Changed 6 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:16 Changed 6 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:17 Changed 6 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko angel_il to commited-master commited-stable
  • Resolution set to fixed
  • severity changed from approved to merged

comment:18 Changed 6 years ago by andrew_b

  • Status changed from testing to closed

comment:19 Changed 6 years ago by egmont

Verified in 4.7.0.3. Thanks!

Note: See TracTickets for help on using tickets.