Ticket #1953 (closed task: fixed)

Opened 14 years ago

Last modified 13 years ago

some cppcheck cleanups

Reported by: slyfox Owned by: slyfox
Priority: minor Milestone: 4.7.5
Component: mc-core Version: master
Keywords: cppcheck Cc:
Blocked By: Blocking:
Branch state: no branch Votes for changeset:

Description (last modified by slyfox) (diff)

​http://apps.sourceforge.net/trac/cppcheck/

Issuing

mc $ cppcheck -a --force .

among many reports we get interesting hits

[./vfs/ftpfs.c:682]: (possible error) Memory leak: host
[./src/util.c:1435]: (error) Resource leak: f

---

Merged as changeset:2c42692c7e0b3e98a694d5988d8c918289a03d64

$ git log 2c42692c7^..2c42692c7

Change History

comment:1 Changed 14 years ago by slyfox

  • Status changed from new to accepted
  • severity changed from no branch to on review

Pushed as
branch:1953_cppcheck_resleaks (2 commits)
tip changeset:fca17611e5d0c38b2898ef68828c0e380fe7ab00

Please review.

comment:2 Changed 14 years ago by iNode

  • Votes for changeset set to iNode

comment:3 Changed 14 years ago by andrew_b

  • Votes for changeset changed from iNode to iNode andrew_b
  • severity changed from on review to approved

comment:4 Changed 14 years ago by slyfox

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Description modified (diff)

comment:5 Changed 14 years ago by slyfox

  • severity changed from approved to merged

comment:6 Changed 14 years ago by slavazanko

  • Status changed from testing to closed
  • Votes for changeset changed from iNode andrew_b to commited-master commited-stable

Cherry-picked and rebased into 4.7.0-stable: c87b4116bda53aded5d99006b454c909ed4ba581

comment:7 Changed 14 years ago by slyfox

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Description modified (diff)

Reseted master and reapplied with fixed typo in label:
new merge tip: changeset:2c42692c7e0b3e98a694d5988d8c918289a03d64

Sorry for the shit.

comment:8 Changed 14 years ago by slyfox

  • Status changed from reopened to closed
  • Resolution set to fixed

comment:9 Changed 14 years ago by slavazanko

Cherry-picked and rebased into 4.7.0-stable: f11325536d6eeb4452bdad004865fe59cd0bf0d7

comment:10 Changed 14 years ago by zaytsev

  • Status changed from closed to reopened
  • Votes for changeset committed-master committed-stable deleted
  • severity changed from merged to no branch
  • Version changed from 4.7.0.1 to master
  • Milestone changed from 4.7.1 to 4.7.5
  • Resolution fixed deleted

comment:11 Changed 14 years ago by zaytsev 

[./lib/vfs/mc-vfs/fish.c:290]: (error) Resource leak: res
[./lib/vfs/mc-vfs/samba/lib/system.c:94]: (error) Invalid number of character ({) when these macros are defined: 'HAVE_SELECT;USE_POLL'.
[./lib/vfs/mc-vfs/smbfs.c:506]: (error) Memory leak: new_entry
[./lib/vfs/mc-vfs/smbfs.c:551]: (error) Memory leak: new_entry
[./lib/vfs/mc-vfs/smbfs.c:597]: (error) Memory leak: new_entry
[./lib/vfs/mc-vfs/tar.c:726]: (error) Resource leak: tard
[./src/editor/editoptions.c:141]: (error) Uninitialized variable: p
[./src/mountlist.c:830]: (error) Memory leak: entry

Any thoughts?

comment:12 Changed 13 years ago by angel_il

  • Branch state set to no branch

26/07/2011

277/277 files checked 100% done

comment:13 Changed 13 years ago by angel_il

  • Type changed from defect to task

comment:14 Changed 13 years ago by angel_il

  • Status changed from reopened to closed
  • Resolution set to fixed
Note: See TracTickets for help on using tickets.