Ticket #1936 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Segfault in History

Reported by: ralesk Owned by: andrew_b
Priority: major Milestone: 4.7.1
Component: mc-core Version: 4.7.0
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

I noticed that if there’s only one entry in an input history (in my case it was Right/Listing? mode.../Mini info), pressing M-p (“Previous history item”) would cause a segmentation fault — I guess it was trying to access the “-1st” element of the array or linked list or whatever, and poked at a bad place this way. Pressing M-n (“Next history item”) emptied the input field and added said empty line to the history, and with two items I couldn’t notice this issue.

Using 4.7 (not 4.7.0.1).

Change History

comment:1 Changed 7 years ago by ralesk

  • Version changed from version not selected to 4.7.0

comment:2 Changed 7 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • severity changed from no branch to on review

Thanks for the bugreport!

Created branch 1936_history_segfault. Parent branch is master.
changeset:7f17e65831fc8ea85ee26d512a1cce0987d749a7

comment:3 Changed 7 years ago by andrew_b

  • Milestone changed from 4.7 to 4.7.1

comment:4 Changed 7 years ago by angel_il

  • Votes for changeset set to angel_il

comment:5 Changed 7 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:6 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from angel_il slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:7 Changed 7 years ago by slavazanko

  • Status changed from testing to closed

Cheery-picked into 4.7.0-stable
changeset:1d1b6011e96ad9a538d75a9471e7ea94625867bf

Note: See TracTickets for help on using tickets.