Ticket #1911 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Use system realpath() instead of own implementation

Reported by: metux Owned by: andrew_b
Priority: major Milestone: 4.7.3
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description

mc_realpath is an own implementation of the POSIX realpath() function. For now, it's calling realpath() when USE_SYSTEM_REALPATH is defined (which is nowhere done).

We should check whether POSIX realpath() works and in this case use it instead of the own implementation.

Change History

comment:1 Changed 7 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Version changed from version not selected to master
  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.3

Created 1911_realpath branch. Parent branch is master.
changeset:84166ac6a3a5d30cd4e3576eba9acafdd72199db

comment:2 Changed 7 years ago by angel_il

  • Votes for changeset set to angel_il

comment:3 Changed 7 years ago by slavazanko

  • Keywords stable-candidate added
  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:4 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Keywords stable-candidate removed
  • Votes for changeset changed from angel_il slavazanko to committed-master committed-stable
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.
changeset:ca0a75df6c473f00834e054908ea57abca20abe0

git log --pretty=oneline 5ab3f7c..ca0a75d

Cherry-picked to master:
changeset:010f631acf5363d5a6c6cb64fd4841b7bd22b12a
changeset:4e93966b0ec89ebfefd5e989519c1cb919b2ddb7

git log --pretty=oneline 0bb908d..4e93966

comment:5 Changed 7 years ago by andrew_b

  • Status changed from testing to closed

comment:6 follow-up: ↓ 7 Changed 7 years ago by zaytsev

To stable you mean...

comment:7 in reply to: ↑ 6 Changed 7 years ago by andrew_b

Replying to zaytsev:

To stable you mean...

Sure. Sorry!

Cherry-picked to 4.7.0-stable:
changeset:010f631acf5363d5a6c6cb64fd4841b7bd22b12a
changeset:4e93966b0ec89ebfefd5e989519c1cb919b2ddb7

git log --pretty=oneline 0bb908d..4e93966
Note: See TracTickets for help on using tickets.