Ticket #1872 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Build fixups (unused variables, etc)

Reported by: metux Owned by: metux
Priority: blocker Milestone:
Component: mc-core Version: 4.7.0-pre4
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by metux) (diff)

Branch:1872_build_fixups
changeset:393a08fac876097259f1587d4e278ce63f347c68

passed all tests, please vote asap as it's critical.

Change History

comment:1 Changed 6 years ago by metux

  • Priority changed from major to blocker

comment:2 Changed 6 years ago by angel_il

will be fixed in #1845

comment:3 Changed 6 years ago by angel_il

  • Blocking 1845 added

comment:4 Changed 6 years ago by angel_il

  • Status changed from new to closed
  • Resolution set to fixed
  • Blocking 1845 removed

comment:5 Changed 6 years ago by metux

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Description modified (diff)
  • severity changed from no branch to on review

comment:6 Changed 6 years ago by metux

The branch also fixes some more things (eg. building w/o vfs).

comment:7 Changed 6 years ago by metux

  • Owner set to metux
  • Status changed from reopened to accepted

comment:8 Changed 6 years ago by metux

  • Milestone changed from 4.7 to 4.7.0

comment:9 Changed 6 years ago by metux

  • Blocking 1823 added

(In #1823) Still breaks on several things fixed by #1872

comment:10 Changed 6 years ago by metux

  • Blocking 1828 added

comment:11 Changed 6 years ago by metux

  • Blocking 1845 added

comment:12 Changed 6 years ago by metux

  • Blocking 1786 added

comment:13 Changed 6 years ago by metux

  • Blocking 1780 added

comment:14 Changed 6 years ago by metux

  • Blocking 1787 added

comment:15 Changed 6 years ago by metux

  • Blocking 1788 added

comment:16 Changed 6 years ago by metux

  • Blocking 1789 added

comment:17 Changed 6 years ago by metux

  • Description modified (diff)

comment:18 Changed 6 years ago by metux

  • Blocking 1787 removed

comment:19 Changed 6 years ago by metux

rebased to current master, now running through testfarm ...

comment:20 follow-up: ↓ 25 Changed 6 years ago by slavazanko

In changeset:413432283c22c38a5211176f4cca5e14b558189a present some MVFS stuff. Is these need to apply in this branch? May be better to move this stuff into special branch?

comment:21 Changed 6 years ago by angel_il

  • Blocking 1845 removed

comment:22 Changed 6 years ago by angel_il

  • Blocking 1786 removed

comment:23 Changed 6 years ago by angel_il

  • Blocking 1788 removed

comment:24 Changed 6 years ago by angel_il

  • Blocking 1789 removed

comment:25 in reply to: ↑ 20 Changed 6 years ago by metux

Replying to slavazanko:

In changeset:413432283c22c38a5211176f4cca5e14b558189a present some MVFS stuff. Is these need to apply in this branch? May be better to move this stuff into special branch?

It's needed to fix problems w/ already present (but yet unused) mvfs stuff.

comment:26 follow-up: ↓ 28 Changed 6 years ago by angel_il

  • Milestone changed from 4.7.0 to 4.7

comment:27 Changed 6 years ago by slavazanko

  • Blocking 1828 removed

comment:28 in reply to: ↑ 26 Changed 6 years ago by metux

Replying to angel_il:

What exactly does that change mean ?

Please keep in mind that we should merge it asap, as it's critical to get MC cleanly built at all.

comment:29 Changed 6 years ago by metux

  • Blocking 1843 added

(In #1843) Buildfarm test still failed, since #1872 not merged yet ;-O

comment:30 Changed 6 years ago by metux

  • Blocking 1906 added

(In #1906) Buildfarm test still fails, since #1872 not yet merged ;-o

comment:31 Changed 6 years ago by metux

  • Blocking 1767 added

(In #1767) Didnt pass buildfarm test (see #1872)

comment:32 Changed 6 years ago by metux

  • Blocking 1812 added

comment:33 Changed 6 years ago by andrew_b

  • Blocking 1906 removed

(In #1906) Removed blockedby #1872 because this branch doesn't produce new compile warnings.

comment:34 Changed 6 years ago by slyfox

I propose to move

    Ticket #1897: Fix compiler warnings/breaks on ignored result values which shouldnt be ignored                              
                                                                                                                               
    Glibc marks several functions, whose returns values should not be ignore,                                                  
    with warn_unused_resultwarn_unused_result.
                                                                                                                               
    Unfortunately we've got a lot of places where exactly these return values                                                  
    *are* ignored (eg. read(), write(), dup(), ... calls), so the compiler                                                     
    *breaks* when building w/ -Werror (which ought to be a MUST for any                                                        
    production build ;-o).                                                                                                     
                                                                                                                               
    Actually, we should have a closer look on it all, whether some results                                                     
    probably have to be handled (eg. to prevent possible leaks).

away from this branch to related #1897 and fix it in a better way: suppress silly warnings and really fix the rest.

Sprinkling 'if () {}' is very hard to read in the end result. I'd like to try another solution, like introducting

/* somewhere in global.h */
#ifdef __GNUC__ /* or something */
#define__mc_unused __attribute__((unused))
#else
#define__mc_unused
#endif /* __GNUC__ */

system("i don't care") __mc_unused;

I'm not sure if it will work though, but it would be ideal, as it's easily grepable and looks exactly the way glibc introduces wur :]

vfsdummy.h removal should contain 2 phases (as it's hard to review real changes in current state):

  1. blind code move from vfsdummy.h to vfs.h

and

  1. patching it.

(or the reverse, as it's easier to do right)

Then patch will look very small and I'll be happy to place a vote here.

comment:35 Changed 6 years ago by andrew_b

  • Blocking 1780 removed

comment:36 Changed 6 years ago by andrew_b

  • Blocking 1843 removed

comment:37 Changed 6 years ago by metux

  • Blocking 1823 removed

comment:38 Changed 6 years ago by slavazanko

  • severity changed from on review to on rework

Branch have lot of conflicts when rebased on current master

comment:39 Changed 6 years ago by slavazanko

  • Blocking 1767 removed

comment:40 Changed 6 years ago by slavazanko

  • Status changed from accepted to testing
  • Resolution set to fixed
  • Blocking 1812 removed

Already in master

comment:41 Changed 6 years ago by slavazanko

  • Status changed from testing to closed
  • Milestone 4.7 deleted

comment:42 Changed 6 years ago by andrew_b

  • Blocking 1812 added

(In #1812) Replying to slavazanko:

Branch incompatible with current master

Partially commits of this branch are in the master one.

comment:43 Changed 6 years ago by andrew_b

  • Blocking 1812 removed
Note: See TracTickets for help on using tickets.