Ticket #1867 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

[PATCH] Don't specify user name for ssh if it's the same as local logged-in user

Reported by: zaytsev Owned by: zaytsev
Priority: major Milestone: 4.7.0
Component: mc-vfs Version: master
Keywords: vfs fish Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

Add the user name to the ssh command line only if it's not the
same as the local logged-in user. OpenSSH will take it as a
default value anyway, but otherwise we'll override
~/.ssh/config settings which might be not what the user wants.

Change History

comment:1 Changed 6 years ago by zaytsev

  • severity changed from no branch to on review

branch: 1867_fish_dont_add_username (parent: master)

comment:2 Changed 6 years ago by zaytsev

branch:1867_fish_dont_add_username (parent:master)

comment:4 Changed 6 years ago by slyfox

changeset:2dd14f8d11c3b931f0805fb5f72d044ea2e29f11

Date:   Mon Dec 7 17:28:39 2009 +0200

    Ticket #1867: fish: omit '-l' parameter for userless URLs

    * Factored out vfs_get_local_username()
    * Moved default-user detection to fish subsystem (URL_ALLOW_ANON)

Slightly changed semantics:
$ mc /#sh:user@machine
starts ssh -l $USER machine

while
$ mc /#sh:127.0.0.1
starts ssh machine

comment:5 Changed 6 years ago by zaytsev

Looks good, hopefully I'll come up with a few minor corrections tonight.

comment:6 Changed 6 years ago by angel_il

  • Votes for changeset set to angel_il

comment:7 Changed 6 years ago by slavazanko

  • Votes for changeset changed from angel_il to angel_il slavazanko
  • severity changed from on review to approved

comment:8 Changed 6 years ago by slavazanko

  • Status changed from new to assigned

comment:9 Changed 6 years ago by zaytsev

There are spelling errors inside. Sorry I was not able to come up with a patch yesterday, but I'm overwhelmed with other things ATM :(

comment:10 Changed 6 years ago by slavazanko

  • severity changed from approved to on rework
  • Milestone changed from 4.7.0 to 4.7

Feel free to change back milestone if branch will ready to vote

comment:11 Changed 6 years ago by zaytsev

  • severity changed from on rework to on review
  • Milestone changed from 4.7 to 4.7.0

Squashed changeset:493d30f049dbf608d580021678c116261aed5915 .

Please review, vote & merge :-)

comment:12 Changed 6 years ago by andrew_b

  • Votes for changeset changed from angel_il slavazanko to angel_il slavazanko andrew_b
  • severity changed from on review to approved

comment:13 Changed 6 years ago by andrew_b

  • Status changed from assigned to testing
  • Votes for changeset changed from angel_il slavazanko andrew_b to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:14 Changed 6 years ago by andrew_b

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.