Ticket #1839 (closed defect: fixed)

Opened 6 years ago

Last modified 6 years ago

Vertical selection considers him self a snake

Reported by: styx Owned by: angel_il
Priority: major Milestone: 4.7.0
Component: mc-core Version: 4.7.0-pre4
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

Test example:
..
...
....
.....
......
..............
.............
............
...........
..........
..*1...*2..

Select from *1 to *2 with vertical selection and continue with pressing up until you can see snake effect (:

Change History

comment:1 Changed 6 years ago by styx

  • Status changed from new to assigned
  • Owner set to angel_il

comment:2 Changed 6 years ago by angel_il

  • severity changed from no branch to on review
  • Milestone changed from 4.7 to 4.7.0

branch: 1839_vertical_selection_enhancement
changeset: bbd4a849ea8f0acd7469215bd30af52c831bbe03

comment:3 Changed 6 years ago by styx

  • severity changed from on review to on rework

Yeah, it is nice of course, you fixed bug with cursor jumping, but this bug is another one (
Just try to perform a test case.

comment:4 Changed 6 years ago by styx

  • Votes for changeset set to styx
  • severity changed from on rework to on review

comment:5 Changed 6 years ago by slavazanko

  • Votes for changeset changed from styx to styx slavazanko
  • severity changed from on review to approved

comment:6 Changed 6 years ago by angel_il

  • Votes for changeset styx slavazanko deleted
  • severity changed from approved to on rework

comment:7 Changed 6 years ago by styx

  • Votes for changeset set to styx

comment:8 Changed 6 years ago by angel_il

  • severity changed from on rework to on review

comment:9 Changed 6 years ago by slavazanko

  • Votes for changeset changed from styx to styx slavazanko
  • severity changed from on review to approved

comment:10 Changed 6 years ago by angel_il

  • Status changed from assigned to testing
  • Votes for changeset changed from styx slavazanko to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:11 Changed 6 years ago by angel_il

  • Status changed from testing to closed

comment:12 Changed 6 years ago by angel_il

  • Status changed from closed to reopened
  • Resolution fixed deleted

comment:13 Changed 6 years ago by angel_il

Test example:

..
...
....
<------>.....
......
<------>..............
.............
<------>............
...........
..........
<------>*1...*2..

Select from *1 to *2 with vertical selection and delete block.

comment:14 Changed 6 years ago by angel_il

  • Votes for changeset committed-master deleted
  • severity changed from merged to on review

comment:15 Changed 6 years ago by angel_il

branch: 1839_vertical_block_delete_fix
changeset: 51bc8adc7ab865c61ff58b3d7237855ee066805c

comment:16 Changed 6 years ago by slavazanko

  • Votes for changeset set to slavazanko

In master: text deleted to the end of string
In branch: text deleted as well.

comment:17 follow-up: ↓ 19 Changed 6 years ago by andrew_b

Unforunately, doesn't work.

Test case:

  1. Create file as described in comment:13
  2. Place cursor at *1 position.
  3. Press S-F3 and press Right to place cursor at *2 position.
  4. Press Up to top line to select vertical block.
  5. Press F8 do delete that block.
  6. Result: in each line the part between *1 position and the line end have been deleted.

Need rework.

comment:18 Changed 6 years ago by angel_il

  • severity changed from on review to on rework

comment:19 in reply to: ↑ 17 Changed 6 years ago by angel_il

  • severity changed from on rework to on review

Replying to andrew_b:

Unforunately, doesn't work.

Test case:

  1. Create file as described in comment:13
  2. Place cursor at *1 position.
  3. Press S-F3 and press Right to place cursor at *2 position.
  4. Press Up to top line to select vertical block.
  5. Press F8 do delete that block.
  6. Result: in each line the part between *1 position and the line end have been deleted.

Need rework.

fixed, please review

comment:20 Changed 6 years ago by andrew_b

  • Votes for changeset changed from slavazanko to slavazanko andrew_b
  • severity changed from on review to approved

comment:21 Changed 6 years ago by angel_il

  • Status changed from reopened to closed
  • Votes for changeset changed from slavazanko andrew_b to committed-master
  • Resolution set to fixed
  • severity changed from approved to merged
Note: See TracTickets for help on using tickets.