Ticket #1563 (closed task: fixed)

Opened 7 years ago

Last modified 7 years ago

Create menu dynamically

Reported by: andrew_b Owned by: andrew_b
Priority: major Milestone: 4.7.0-pre4
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description

Currently, menu creates as static arrays. This doesn't provide flexible menu operations in run-time: added or remove some items. At this time it is not needed, but in future... Who knows? :)
The proposition is: create menus as items of dynamic arrays (GPtrArray).

Branch: HACK_menu. Initial changeset:5d2ceeac1989b381f169441c6f463ceeee38977a

Some visual features:

  • for each drop menu, the selected item is saved;
  • Home and End keys are handled.

Attachments

hotkey-label.diff (3.0 KB) - added by angel_il 7 years ago.

Change History

comment:1 Changed 7 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b

comment:2 Changed 7 years ago by andrew_b

  • Blocking 320 added

comment:3 Changed 7 years ago by andrew_b

  • Blocking 1654 added

(In #1654) Home/End? keys are handled in #1563.

comment:4 Changed 7 years ago by slavazanko

Also, after #212 need to show actual hotkey from keybindings-file

comment:5 Changed 7 years ago by andrew_b

  • Blocking 1653 added

(In #1653) Accelerators in editor main menu are implemented in #1563.
Please wait for merge that branch into master one.

comment:6 Changed 7 years ago by andrew_b

  • Milestone changed from 4.7 to 4.7.0-pre4

Changed 7 years ago by angel_il

comment:7 Changed 7 years ago by andrew_b

  • severity changed from no branch to on review

Branch HACK_menu.
Inital changeset:97a510a72eef154f60a3ea2515ff8b9e4bff4d9d

Please review.

comment:8 Changed 7 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:9 Changed 7 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:10 Changed 7 years ago by andrew_b

  • Votes for changeset changed from slavazanko angel_il to commited-master
  • severity changed from approved to merged

Merged to master.

git log --pretty=oneline a563b5d..21fd13b

comment:11 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:12 Changed 7 years ago by andrew_b

  • Status changed from testing to closed

comment:13 Changed 7 years ago by andrew_b

  • Blocking 320, 1653, 1654 removed
Note: See TracTickets for help on using tickets.