Ticket #1500 (reopened defect)

Opened 7 years ago

Last modified 14 months ago

Segmentation fault while background copying

Reported by: IMDagger Owned by: slavazanko
Priority: major Milestone: Future Releases
Component: mc-core Version: 4.8.7
Keywords: background, copy, ftp Cc: imdagger@…, mva@…
Blocked By: Blocking:
Branch state: no branch Votes for changeset: committed-master

Description

Test case:

  • create file with name "test" in "tmp" directory (for example)
  • create directory with same name ("test") in other "tmp2" directory (for example)
  • try to copy or move file "test" into "tmp2" in background mode
  • wait for some time

Attachments

background.diff (6.0 KB) - added by IMDagger 7 years ago.
background_fix_assert.diff (2.9 KB) - added by IMDagger 7 years ago.
Fix for "assert trouble" when file is replaced
full_bg_patch.diff (7.6 KB) - added by IMDagger 7 years ago.
Last patch and fix for process list
0001-Fixed-problems.patch (8.5 KB) - added by IMDagger 7 years ago.
Same as last, but in patch-format and with description

Change History

Changed 7 years ago by IMDagger

comment:1 Changed 7 years ago by IMDagger

  • Cc imdagger@… added

comment:2 Changed 7 years ago by angel_il

  • Milestone changed from 4.7 to 4.7.0-pre4

comment:3 Changed 7 years ago by slavazanko

  • Owner set to slavazanko
  • Status changed from new to accepted

comment:4 Changed 7 years ago by slavazanko

Looks good, but if need replace existing file assertion raised:

** (mc:25716): CRITICAL **: file_progress_real_query_replace: assertion `ctx->ui != NULL' failed

comment:5 Changed 7 years ago by slavazanko

  • severity changed from no branch to on rework

Created branch 1500_segfault_on_bg_copy (c75ebb2ab9b9002bc26741968092d32dc048104d)

Status: on rework (need to fix assertion).

comment:6 Changed 7 years ago by slavazanko

  • Milestone changed from 4.7.0-pre4 to 4.7

Changed 7 years ago by IMDagger

Fix for "assert trouble" when file is replaced

comment:7 Changed 7 years ago by IMDagger

Last patch is for (c75ebb2ab9b9002bc26741968092d32dc048104d), but branch has trouble with background processes yet. Trouble:

  • copy file in background
  • look at background process list by C-x j

Process has been already done, but still draw in list.

Changed 7 years ago by IMDagger

Last patch and fix for process list

Changed 7 years ago by IMDagger

Same as last, but in patch-format and with description

comment:8 Changed 7 years ago by slavazanko

  • Keywords rework, removed
  • severity changed from on rework to on review
  • Milestone changed from 4.7 to 4.7.0-pre4

Ok, all looks good.

remind: branch 1500_segfault_on_bg_copy

Changesets:

Review, please.

comment:9 Changed 7 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:10 Changed 7 years ago by iNode

  • Votes for changeset changed from slavazanko to slavazanko iNode
  • severity changed from on review to approved

comment:11 Changed 7 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from slavazanko iNode to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:12 Changed 7 years ago by slavazanko

  • Status changed from testing to closed

comment:13 follow-up: ↓ 14 Changed 3 years ago by mva

  • Status changed from closed to reopened
  • Cc mva@… added
  • Version changed from 4.7.0-pre1 to 4.8.7
  • Branch state set to no branch
  • Milestone 4.7.0-pre4 deleted
  • Keywords copy, ftp added; copy removed
  • Resolution fixed deleted

Sorry for bumping old fixed bug, but I experience it with latest available in distro (4.8.7) mc (not checked on trunk version) while I copy files to FTP server in background.

comment:14 in reply to: ↑ 13 Changed 3 years ago by andrew_b

Replying to mva:

Sorry for bumping old fixed bug, but I experience it with latest available in distro (4.8.7) mc (not checked on trunk version) while I copy files to FTP server in background.

Please describe your actions in details: what you do and what you get. What VFS timeout is set up? Is total copy time more than VFS timeout or not?

comment:15 Changed 3 years ago by mva

0) VFS timeout = default = 60s
1) F9->Right panel->FTP Connection->[reqs]->connect
2) open remote subdir,
3) select some directory (.git, for example) in left panel and F5->Background
3a) [don't know, if it is mandatory condition] wait some time. Maybe, more, than 60s.
4) select some another directory in left panel and F5->Background
5) Ta-dam! We get tons of such errors.

comment:16 Changed 14 months ago by andrew_b

  • Milestone set to Future Releases
Note: See TracTickets for help on using tickets.