Ticket #1451 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Wrong charset dialog placement

Reported by: smart Owned by: andrew_b
Priority: major Milestone: 4.7.0-pre3
Component: mc-core Version: master
Keywords: Cc: isee@…
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master

Description (last modified by andrew_b) (diff)

Steps to reproduce:

  1. Choose the horizontal panel layout
  2. Press Ctrl-T to popup the panel's charset dialog

You will see the half of the dialog peeping out of the left side.

Change History

comment:1 Changed 7 years ago by smart

  • Cc isee@… added
  • Version changed from 4.7.0-pre1 to master

comment:2 Changed 7 years ago by andrew_b

  • Status changed from new to accepted
  • severity changed from no branch to on review
  • Version changed from master to 4.7.0-pre2
  • Milestone changed from 4.7 to 4.7.0-pre3
  • Owner set to andrew_b
  • Description modified (diff)

Created 1561_panel_encoding_dialog_position branch. Parent branch: master.
changeset:0c7e68348bbbb734c316481df9c03210a74efb4b

comment:3 follow-up: ↓ 4 Changed 7 years ago by iNode

r = select_charset (0, offset, source_codepage, FALSE);

should be out of branching.

comment:4 in reply to: ↑ 3 Changed 7 years ago by andrew_b

Replying to iNode:

r = select_charset (0, offset, source_codepage, FALSE);

should be out of branching.

No :) Offset is "y offset" for horizontal_split and "x offset" otherwise.

if (horizontal_split) { 
    r = select_charset (0, offset, source_codepage, FALSE); 
} else { 
    r = select_charset (offset, 0, source_codepage, FALSE); 
} 

comment:5 Changed 7 years ago by angel_il

  • Votes for changeset set to angel_il

comment:6 Changed 7 years ago by iNode

  • Votes for changeset changed from angel_il to angel_il iNode
  • severity changed from on review to approved

Yes, you are right. :)

comment:7 Changed 7 years ago by andrew_b

  • Votes for changeset changed from angel_il iNode to commited-master
  • severity changed from approved to merged

comment:8 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:9 Changed 7 years ago by andrew_b

  • Status changed from testing to closed

comment:10 Changed 7 years ago by andrew_b

  • Status changed from closed to reopened
  • Votes for changeset commited-master deleted
  • Version changed from 4.7.0-pre2 to master
  • Resolution fixed deleted
  • severity changed from merged to no branch

Incorrect charset menu location for 'Long file list' lising mode.

comment:11 Changed 7 years ago by andrew_b

  • Status changed from reopened to accepted

comment:12 Changed 7 years ago by andrew_b

  • severity changed from no branch to on review

Created branch 1451_chahset_dlg_place_panel_long_list. Parent branch: master.
changeset:fafd33e8cd5b9288891c36c69be65de8cf741fb2

comment:13 Changed 7 years ago by slavazanko

  • Votes for changeset set to slavazanko

comment:14 Changed 7 years ago by angel_il

  • Votes for changeset changed from slavazanko to slavazanko angel_il
  • severity changed from on review to approved

comment:15 Changed 7 years ago by andrew_b

  • Votes for changeset changed from slavazanko angel_il to commited-master
  • severity changed from approved to merged

comment:16 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:17 Changed 7 years ago by andrew_b

  • Status changed from testing to closed

comment:18 Changed 7 years ago by andrew_b

  • Status changed from closed to reopened
  • Votes for changeset commited-master deleted
  • Resolution fixed deleted
  • severity changed from merged to on rework

Dialog is located incorrect if this dialog is called from menu. Dialog is always placed over active panel even it is called from inactive panel menu.

How to reproduce:

  1. Set left panel active.
  2. Call "Right" menu.
  3. Call "Encoding..." menu item.

Result: dialog raised over left panel.
Expected: dialog raised over right panel.

comment:19 Changed 7 years ago by andrew_b

  • severity changed from on rework to on review

Cretaed 1451_panel_choose_codepage_dlg_position branch. Parent branch: master.
changeset:1ee0e5ce580445e0a43ad5268a9e582a72aee105

comment:20 follow-up: ↓ 21 Changed 7 years ago by iNode

Thanks for code, but it still invalid on some non equal split layouts
(i.e. horizontal 5x43).

Why we can't just position dialog in center of whole display space instead just one panel?
Listing mode and sort dialogs centered duly, why we need special case for Choose codepage?

comment:21 in reply to: ↑ 20 Changed 7 years ago by andrew_b

Replying to iNode:

Why we can't just position dialog in center of whole display space instead just one panel?
Listing mode and sort dialogs centered duly, why we need special case for Choose codepage?

Done in the changeset:e2e4c1a06fad619b6ae627a809d79b88d5456f3d

comment:22 Changed 7 years ago by iNode

  • Votes for changeset set to iNode

Thanks!

comment:23 Changed 7 years ago by slavazanko

  • Votes for changeset changed from iNode to iNode slavazanko
  • severity changed from on review to approved

Okay, but keep in mind, all panel-elated dialogs in future will better to place near panel, rather than place at center of screen.

comment:24 Changed 7 years ago by andrew_b

  • Status changed from reopened to closed
  • Votes for changeset changed from iNode slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

Merged to master.

git log --pretty=oneline 5f3447a..5287f9c
Note: See TracTickets for help on using tickets.