Ticket #1445 (closed enhancement: fixed)

Opened 7 years ago

Last modified 6 years ago

capability to remove history items wanted

Reported by: iNode Owned by: andrew_b
Priority: minor Milestone: 4.7.1
Component: mc-core Version: master
Keywords: Cc:
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description

Any history items in history list should be deleted by
C-d/Del, and C-l should clean whole history list.

Change History

comment:1 Changed 7 years ago by andrew_b

  • Owner set to andrew_b
  • Status changed from new to accepted

comment:2 Changed 7 years ago by angel_il

  • Version changed from 4.7.0-pre1 to master
  • Milestone changed from 4.7.0-pre2 to 4.7.0-pre3

comment:3 Changed 7 years ago by andrew_b

  • Milestone changed from 4.7.0-pre3 to 4.7.0-pre4

comment:4 Changed 7 years ago by andrew_b

  • Milestone changed from 4.7.0-pre4 to 4.7

comment:5 Changed 7 years ago by andrew_b

  • Priority changed from major to minor
  • Milestone changed from 4.7 to 4.7.1

Created 1445_remove_history_items branch. Parent branch: master.
Initial changeset:a8d490de07601ab89345b9ccede4c5451abb5e3f

comment:6 Changed 7 years ago by andrew_b

  • severity changed from no branch to on review

comment:7 Changed 7 years ago by andrew_b

comment:8 follow-up: ↓ 9 Changed 7 years ago by iNode

Good work, thanks.

Isn't it should be repainted after element delete?
(i.e. when you delete last item, previous should be last in list widget, instead of new empty line)

Also, C-l behaviour not implemented.

comment:9 in reply to: ↑ 8 Changed 7 years ago by andrew_b

  • severity changed from on review to on rework

Replying to iNode:

Good work, thanks.

:)

Isn't it should be repainted after element delete?
(i.e. when you delete last item, previous should be last in list widget, instead of new empty line)

OK. I'll try to fix that.

Also, C-l behaviour not implemented.

C-l is used to repaint the screen. We should find another shortcut. Maybe Shift-Del?

Also, I think the confirmaton of list clean is needed (or even confirmation of a single item removal).

comment:10 follow-up: ↓ 11 Changed 7 years ago by iNode

Yes, I'm agree either with confirmation dialog need and alternative (customizable?) shortcut.
Shift-Del looks good but should be also simple character alternative (for keyboards without Del key).

comment:11 in reply to: ↑ 10 ; follow-up: ↓ 12 Changed 7 years ago by andrew_b

Replying to iNode:

Yes, I'm agree either with confirmation dialog need

Confirmation of what? Clean of whole list or delete of a single list item?

and alternative (customizable?) shortcut. Shift-Del looks good but should be also simple character alternative (for keyboards without Del key).

Keybindings for WListbox widget are not implemented yet and should be implemented ASAP.

comment:12 in reply to: ↑ 11 Changed 7 years ago by iNode

Confirmation for whole list cleanup.

Replying to andrew_b:

Replying to iNode:

Yes, I'm agree either with confirmation dialog need

Confirmation of what? Clean of whole list or delete of a single list item?

and alternative (customizable?) shortcut. Shift-Del looks good but should be also simple character alternative (for keyboards without Del key).

Keybindings for WListbox widget are not implemented yet and should be implemented ASAP.

comment:13 Changed 7 years ago by andrew_b

  • severity changed from on rework to on review

Fixed:

  • keybindings: d or Del to remove current item of history; D or Shift-Del to clean the history;
  • list scrolling if last item is deleted;
  • cleanup history confirmation;

Initlial changeset:2470831648751d2776392f124c8adb83895d8a3d
Please review.

comment:14 Changed 7 years ago by iNode

Confirm 1 and 3, second - behaviour not changed.

$ mc -V
GNU Midnight Commander 4.7.0.1-176-gf00ff08

May be we talk about another things? When delete last (or any other line),
list widget should be correctly scrolled, but now it just shift another items up.

Example:
ls
cd
rm -rf
<empty line>

After delete (on cd):
ls
rm -rf
<empty line>
<empty line>

After delete on rm -rf:
ls
<empty line>
<empty line>
<empty line>

Should be:
ls
<empty line>

comment:15 Changed 7 years ago by iNode

  • Votes for changeset set to iNode

Ok, thanks for all changes. Now it works properly.

comment:16 Changed 7 years ago by slavazanko

  • Votes for changeset changed from iNode to iNode slavazanko
  • severity changed from on review to approved

comment:17 Changed 7 years ago by andrew_b

  • Status changed from accepted to testing
  • Votes for changeset changed from iNode slavazanko to commited-master
  • Resolution set to fixed
  • severity changed from approved to merged

comment:18 Changed 7 years ago by andrew_b

  • Keywords stable-candidate added

comment:19 Changed 7 years ago by andrew_b

changeset:7b9226c5da3a81fb758bee70aafe05bb64d37464 (#2068) must be cherry-picked to 4.7.0-stable after cherry-pick of this ticket feature.

comment:20 Changed 6 years ago by zaytsev

  • Votes for changeset changed from commited-master to committed-master

comment:21 Changed 6 years ago by andrew_b

  • Status changed from testing to closed

comment:22 Changed 6 years ago by andrew_b

#2299 fixes history show.

comment:23 Changed 6 years ago by andrew_b

  • Keywords stable-candidate removed
  • Votes for changeset changed from committed-master to committed-master committed-stable
Note: See TracTickets for help on using tickets.