Ticket #137 (closed task: fixed)

Opened 7 years ago

Last modified 6 years ago

[PATCH] (git) Fixup homepage url

Reported by: Enrico.Weigelt@…> Owned by: metux
Priority: critical Milestone: 4.6.2
Component: mc-core Version:
Keywords: committed-master committed-mc-4.6 vote-slavazanko vote-winnie Cc:
Blocked By: Blocking:
Branch state: Votes for changeset:

Description (last modified by metux) (diff)

This patch fixes the homepage url to http://www.midnight-commander.org/ in various locations

Commited to master and mc-4.6

Attachments

git08123111-new-homepage.diff (15.1 KB) - added by anonymous 7 years ago.
Added by email2trac

Change History

Changed 7 years ago by anonymous

Added by email2trac

comment:1 Changed 7 years ago by anonymous

  • id set to 137

This message has 1 attachment(s)

comment:2 Changed 7 years ago by metux

  • Priority changed from major to critical
  • Version 4.6.1 deleted
  • Summary changed from [PATCH] git: Fixup homepage url to [PATCH] (git) Fixup homepage url
  • Description modified (diff)
  • Milestone set to 4.6.2

comment:3 Changed 7 years ago by slavazanko

  • Type changed from defect to task

I agree with idea in patch. Homepage need to change in any case.

+1.

comment:4 Changed 7 years ago by winnie

  • Owner set to metux
  • Status changed from new to assigned

Tested on master and works fine..
As far as I can see this were all places where the url has to be changed.. Therefore:

+1

@Enrico? I've assigned you to the ticket. I guess this is what you wanted? :) Next time simply accept it ;-)

comment:5 Changed 7 years ago by Enrico Weigelt

:)

I'm not sure if that's the right way - shouldnt the ticket be
assigned to someone with commit authority ?

cu

comment:6 Changed 7 years ago by slavazanko

Reassing of ticket mean other developer (or visitor) need to rework patch, give more info in comment, continue working with ticket, etc... After this complete, ticket reassigning back. Or not reassign back, in this case assigner (if developer) need to apply patch (create branch).

About named of branches... I think, simply to 'Summary' of ticket... or simular to patch name...

For example:
git-branch 'fixup-homepage-url' # all letters in lower case
or
git-branch 'git08123111-new-homepage'

P.S. This additional to workflow in mail list... details appear in the process of works:)

comment:7 Changed 7 years ago by metux

  • Keywords review added

comment:8 Changed 7 years ago by slavazanko

Duplicate #138

comment:9 Changed 7 years ago by winnie

  • Keywords vote-slavazanko vote-winnie added

I add vote-slavazanko and vote-winnie as we already voted in the text for this patch.

@metux: If you want I'll help you this evening in merging this patch now into the mc-4.6 branch okay?

comment:10 Changed 7 years ago by winnie

  • Keywords approved added

Forgot to add approved keyword

comment:11 Changed 7 years ago by slavazanko

I add vote-slavazanko and vote-winnie as we already voted in the text for this patch.

agree.

comment:12 Changed 7 years ago by metux

  • Keywords review removed

Removed the review keyword, since it's now approved.

BTW: should we introduce news keywords for patches that have been applied ?

comment:13 Changed 7 years ago by winnie

no.. simply resolve the ticket as fixed. I'll close this ticket then later (as only Ticket_admin is allowed to do this currently.. I think I'll change this behaviour in the future).

comment:14 Changed 7 years ago by metux

  • Keywords committed-master committed-mc-4.6 added; approved removed
  • Description modified (diff)

comment:15 Changed 7 years ago by winnie

  • Status changed from assigned to testing
  • Resolution set to fixed

comment:16 Changed 7 years ago by winnie

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.