Ticket #3609 (closed defect: fixed)
[PATCH] mc.keymap: remove redundant key.default.keymap
| Reported by: | and | Owned by: | zaytsev |
|---|---|---|---|
| Priority: | minor | Milestone: | 4.8.17 |
| Component: | mc-core | Version: | master |
| Keywords: | Cc: | ||
| Blocked By: | Blocking: | ||
| Branch state: | merged | Votes for changeset: | committed-master |
Description
Remove mc.keymap symlink to mc.default.keymap and place mc.default.keymap as mc.keymap file.
Please consider it's worth to have a *default* naming tag?
If yes, all other mc etc files should include a *default* tag.
If no, consider to take this patch.
Save space and fix RPMlint warning found by OBS Framework (build.opensuse.org)
Attachments
Change History
Changed 8 years ago by and
- Attachment mc-3609-mc.keymap-remove-redundant-key.default.keymap.patch added
comment:2 follow-up: ↓ 3 Changed 8 years ago by zaytsev
I don't like this patch; I think the original idea was to have several keymaps, so that one could switch the symlink to the one she/he likes. Unfortunately, this never worked correctly and a copy of the file was installed instead of a symlink.
Instead of accepting this patch, I would rather like to see the Makefile.am fixed to create a symlink mc.keymap to mc.default.keymap upon installation. See here on how to do this correctly:
http://www.gnu.org/software/automake/manual/automake.html#Extending
Andrew, do you have an opinion on this?
comment:3 in reply to: ↑ 2 Changed 8 years ago by andrew_b
Replying to zaytsev:
I don't like this patch;
Me too.
I think the original idea was to have several keymaps, so that one could switch the symlink to the one she/he likes.
Yes, exactly.
comment:5 follow-up: ↓ 9 Changed 8 years ago by and
For fixing last RPMlint warning
mc.x86_64: W: script-without-shebang /usr/lib/mc/mc.sh mc.x86_64: W: script-without-shebang /usr/lib/mc/mc-wrapper.sh mc.x86_64: W: script-without-shebang /usr/lib/mc/mc.csh mc.x86_64: W: script-without-shebang /usr/lib/mc/mc-wrapper.csh This text file has executable bits set or is located in a path dedicated for executables, but lacks a shebang and cannot thus be executed. If the file is meant to be an executable script, add the shebang, otherwise remove the executable bits or move the file elsewhere.
are you agree to remove executable bits?
These scripts should used as shell include only, e.g.:
. /usr/lib/mc/mc-wrapper.sh
comment:7 Changed 8 years ago by zaytsev
- Branch state changed from no branch to on review
Branch: 3609_keymap_symlink
Initial changeset: 43c11f32b8720d100fc76dee4884db400038e28d
comment:8 Changed 8 years ago by andrew_b
- Votes for changeset set to andrew_b
- Branch state changed from on review to approved
comment:9 in reply to: ↑ 5 Changed 8 years ago by zaytsev
Replying to and:
are you agree to remove executable bits?
These scripts should used as shell include only, e.g.:
. /usr/lib/mc/mc-wrapper.sh
Yes, I think that's fine, they get the bit, because they are installed as SCRIPTS.
comment:10 Changed 8 years ago by zaytsev
- Status changed from accepted to testing
- Votes for changeset changed from andrew_b to committed-master
- Resolution set to fixed
- Branch state changed from approved to merged
Merged to master: db074dd9541300d764b5eb5152908e148b297f02
