Ticket #2082 (closed defect: fixed)

Opened 5 years ago

Last modified 4 years ago

If dialog was canceled, input line content is saved in history

Reported by: andrew_b Owned by: andrew_b
Priority: major Milestone: 4.7.2
Component: mc-core Version: 4.7.1
Keywords: Cc: gotar@…
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description (last modified by andrew_b) (diff)

For example, get the 'Select' dialog.

How to reproduce:

  1. Open "Select" dialog (press "gray *").
  2. Current content of mask field is '*'.
  3. Enter other mask: '*.c'.
  4. Close dialog by double pressing of Esc.
  5. Open dialog again.

Result: content of mask input line is '*.c'.
Expected result: content of mask input line is '*'.

Change History

comment:1 Changed 5 years ago by andrew_b

  • Status changed from new to accepted
  • Owner set to andrew_b
  • Milestone changed from 4.7 to 4.7.2

Created 2082_cancel_dlg_input_line branch. Parent branch is master.
Initial changeset:e595456e40ae9108dc23bfe742292041f09ec9dc

comment:2 Changed 5 years ago by andrew_b

  • severity changed from no branch to on review

comment:3 Changed 5 years ago by andrew_b

  • Description modified (diff)

comment:4 Changed 5 years ago by angel_il

  • Votes for changeset set to angel_il

comment:5 Changed 5 years ago by styx

  • Summary changed from If dialog was canceled, inpul line content is saved in history to If dialog was canceled, input line content is saved in history

comment:6 Changed 5 years ago by styx

  • Votes for changeset changed from angel_il to angel_il styx

comment:7 Changed 5 years ago by styx

  • severity changed from on review to approved

comment:8 Changed 5 years ago by andrew_b

  • Keywords stable-candidate added
  • Votes for changeset changed from angel_il styx to commited-master
  • severity changed from approved to merged

comment:9 Changed 5 years ago by andrew_b

  • Status changed from accepted to testing
  • Resolution set to fixed

comment:10 Changed 4 years ago by andrew_b

  • Status changed from testing to closed
  • Keywords stable-candidate removed
  • Votes for changeset changed from commited-master to commited-master commited-stable

Cherry-picked to 4.7.0-stable

28a993f01708afd11f86ff984c46dca9aacdd09d Ticket #2077: free kill_buffer after WInput destroy.
14a45774d6fd055c5ce10741cc2263d1e9ab9155 WInput: type accuracy.
72134c1ed7885141c7e16d9d0a40c2bd1863d420 Ticket #2082: don't save input line content in history if dialog was canceled.

comment:11 Changed 4 years ago by gotar

  • Cc gotar@… added

Now the entries removed from history are not deleted too if dialog is closed. One must search for anything to really get rid of those.

Note: See TracTickets for help on using tickets.