Ticket #1982 (closed defect: fixed)

Opened 14 years ago

Last modified 14 years ago

Double free corruption opening gzip archive

Reported by: jnovy Owned by: slavazanko
Priority: major Milestone: 4.7
Component: mcedit Version: 4.7.0.1
Keywords: Cc: pahan@…
Blocked By: Blocking:
Branch state: Votes for changeset: committed-master committed-stable

Description (last modified by andrew_b) (diff)

To reproduce:

  1. touch /tmp/IzV-Útěk_do_bezpečí.gz
  2. open mc
  3. move cursor at /tmp/IzV-Útěk_do_bezpečí.gz
  4. press F4
  5. you will see an error message, press Dismiss
  6. KABOOM

For additional info see:
​https://bugzilla.redhat.com/show_bug.cgi?id=559496

Change History

comment:1 Changed 14 years ago by Hubbitus

  • Cc pahan@… added

comment:2 Changed 14 years ago by andrew_b

  • Version changed from version not selected to 4.7.0.1
  • Component changed from mc-core to mc-vfs

comment:3 Changed 14 years ago by andrew_b

Seems something is missed between 3 and 4 steps.

comment:4 Changed 14 years ago by jnovy

Yes, sorry, the mostimportant bit is step:

3.5 Press F4

:)

comment:5 Changed 14 years ago by andrew_b

  • Description modified (diff)

OK, I've fixed description.

comment:6 Changed 14 years ago by slavazanko

  • Status changed from new to accepted
  • Owner set to slavazanko

As fact, it's no double free.

I have some idea about... next comment will contain branch name and initial changeset :)

comment:7 Changed 14 years ago by slavazanko

  • severity changed from no branch to on review

Created branch 1982_segfault_on_gz_archive
Initial changeset:3452a74f1b95db8d8b15e6ba5898825137bd8136

review, please.

comment:8 Changed 14 years ago by andrew_b

  • Component changed from mc-vfs to mcedit

comment:9 Changed 14 years ago by slyfox

Would be nice to see cleanup patch and actual change in 2 separate patches.

comment:10 Changed 14 years ago by slavazanko

Branch rebased. One commit was splitted:

Review.

comment:11 Changed 14 years ago by slyfox

  • Votes for changeset set to slyfox

Looks way nicer, thanks.

comment:12 Changed 14 years ago by jnovy

  • Votes for changeset changed from slyfox to slyfox, jnovy

Looks good to me. Tested and worked on x86_64.

comment:13 Changed 14 years ago by andrew_b

  • Votes for changeset changed from slyfox, jnovy to slyfox, jnovy andrew_b
  • severity changed from on review to approved

comment:14 Changed 14 years ago by slavazanko

  • Status changed from accepted to testing
  • Votes for changeset changed from slyfox, jnovy andrew_b to commited-master commited-stable
  • Resolution set to fixed
  • severity changed from approved to merged

master: ba9c1b1de64df18ebe39768c914ff1bdf4de7651

stable:

comment:15 Changed 14 years ago by slavazanko

  • Status changed from testing to closed
Note: See TracTickets for help on using tickets.